Skip to content

Conversation

@ngzhian
Copy link
Member

@ngzhian ngzhian commented Sep 26, 2022

@dtig I think this is the right flag?

@RReverser
Copy link
Member

So... is it?

@ngzhian
Copy link
Member Author

ngzhian commented Oct 4, 2022

Probably not, enable-experimental-webassembly-features implies --wasm-staging, but we need --wasm-experimental-relaxed-simd. I think there might not be a Chrome flag for this yet? @dtig

@dtig
Copy link
Member

dtig commented Oct 4, 2022

@ngzhian is right, that this needs to be in wasm-staging, both of these should happen soon though - there's a pending instruction to moving to staging, and I'll be adding a chrome flag for ease of experimentation. So while this PR isn't quite right for now, but it will be applicable soon. Perhaps leave it open and I can merge with the Chrome version where it's supported flagged?

@dschuff
Copy link
Member

dschuff commented Oct 4, 2022

so there's a v8 flag --experimental-wasm-relaxed-simd? In that case we could just do what we do for memory64 and extended-const.

@dtig
Copy link
Member

dtig commented Jan 12, 2023

We do have a chrome flag now (landed in Nov, but I forgot to update this thread). The flag is WebAssemblyRelaxedSimd, and is available from Chrome 110 onwards.

@dschuff
Copy link
Member

dschuff commented Jan 12, 2023

the format for flags in chrome://flags in this file is e.g. chrome://flags/#enable-webassembly-relaxed-simd

@dschuff
Copy link
Member

dschuff commented Jan 12, 2023

Interestingly, this page's general format doesn't easily support listing both a version and a flag, since the flag icon replaces the version number in the box.

@RReverser
Copy link
Member

doesn't easily support listing both a version and a flag, since the flag icon replaces the version number in the box.

Yeah the idea is that if something is under the flag, then people will want to use a flag on a bleeding-edge version of the browser to stay up-to-date with spec anyway, and if something is stable, then minimal version is useful.

@dschuff
Copy link
Member

dschuff commented Feb 14, 2023

I think this isn't "staged" yet, so the flag needs to be chrome://flags/#enable-webassembly-relaxed-simd

@chicoxyzzy
Copy link
Member

On the website it says Requires flag --js-flags=--experimental-wasm-relaxed-simd already. Should we close this PR?

@dschuff
Copy link
Member

dschuff commented Mar 16, 2023

Actually I think https://chromium-review.googlesource.com/c/v8/v8/+/4285497 means that as of Chrome 112, relaxed SIMD should be enabled with the flag in this PR (instead of its own flag). So (assuming that developers are using pre-stable versions of Chromium for testing pre-release wasm features as they should) maybe we should actually merge this.

@dschuff
Copy link
Member

dschuff commented Mar 16, 2023

OK, I just checked and found several recent updates in Chrome and created #328 to cover those, so I think we can actually close this.

@chicoxyzzy
Copy link
Member

#328 has been merged

@chicoxyzzy chicoxyzzy closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants