Empty the pending data slot when an exception is thrown in the AWP construction#2105
Merged
hoch merged 3 commits intoWebAudio:masterfrom Dec 2, 2019
Merged
Empty the pending data slot when an exception is thrown in the AWP construction#2105hoch merged 3 commits intoWebAudio:masterfrom
hoch merged 3 commits intoWebAudio:masterfrom
Conversation
rtoy
reviewed
Nov 22, 2019
| using | ||
| <a href="https://www.w3.org/TR/html50/webappapis.html#the-errorevent-interface">ErrorEvent</a> | ||
| at <var>nodeReference</var>. | ||
| 1. If any of following steps throws any exception: |
Member
There was a problem hiding this comment.
Phrasing here is a bit awkward. Perhaps it would sound better if you said:
If any of following steps throws any exception, perform these steps to handle the exception
Can't think of a good way to phrase this because "following steps" is a bit ambiguous. Is "following steps" the new steps you've added as a sub step of this one, or is it the other steps in this algorithm at the same level as this item?
Member
Author
There was a problem hiding this comment.
I rephrased a bit. PTAL again.
rtoy
approved these changes
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2096.
cc @karlt
Preview | Diff