Skip to content

Use IDL default value syntax for addFrom*() #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
foolip merged 1 commit into from
Aug 2, 2019
Merged

Use IDL default value syntax for addFrom*() #59

foolip merged 1 commit into from
Aug 2, 2019

Conversation

@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Aug 2, 2019 •
edited by pr-preview bot
Loading

Just some cleanup before #58.

Preview | Diff

@saschanaz saschanaz requested a review from foolip August 2, 2019 08:23
foolip
foolip approved these changes Aug 2, 2019
View reviewed changes
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@foolip foolip merged commit 984c5d9 into master Aug 2, 2019
@foolip foolip deleted the default-value branch August 2, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@foolip foolip foolip approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschanaz @foolip