Fix adding element after DOM is already loaded #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add a
<code-input>
element to the DOM after the webpage is already loaded, the element isn't set up properly. This happens because we're always adding aDOMContentLoaded
listener, even when that event has already been fired before.Similarly, when you remove a
<code-input>
from the DOM before it has had the chance to set up, thedisconnectedCallback
would throw becausethis.mutationObserver
wasn't set yet.