Skip to content

Fix adding element after DOM is already loaded #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2025
Merged

Fix adding element after DOM is already loaded #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
033549c
Set up immediately if document is already loaded
MattiasBuelens Aug 18, 2025
4cadc45
Fix disconnectedCallback when called before setup
MattiasBuelens Aug 18, 2025
960fc70
Add couple of tests for code-input after load
WebCoder49 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions code-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,8 +831,12 @@ var codeInput = {
if (this.templateObject != undefined) {
// Template registered before loading
this.classList.add("code-input_registered");
// Children not yet present - wait until they are
window.addEventListener("DOMContentLoaded", this.setup.bind(this))
if (document.readyState === 'loading') {
// Children not yet present - wait until they are
window.addEventListener("DOMContentLoaded", this.setup.bind(this))
} else {
this.setup();
}
}
}

Expand All @@ -859,7 +863,9 @@ var codeInput = {
}

disconnectedCallback() {
this.mutationObserver.disconnect();
if (this.mutationObserver) {
this.mutationObserver.disconnect();
}
}

/**
Expand Down
8 changes: 8 additions & 0 deletions tests/tester.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,14 @@ console.log("I've got another line!", 2 < 3, "should be true.");`);
console.log("I've got another line!", 2 &lt; 3, "should be true.");
`); // Extra newline so line numbers visible if enabled

const programmaticCodeInput = document.createElement("code-input");
document.body.append(programmaticCodeInput);
programmaticCodeInput.focus();
document.execCommand("insertText", false, "Hello, World!");
assertEqual("Core", "Programmatically-created element JS-accessible value", programmaticCodeInput.value, "Hello, World!");
await waitAsync(50);
assertEqual("Core", "Programmatically-created element rendered value", programmaticCodeInput.preElement.textContent, "Hello, World!\n");

// Event Listener Tests
// Function type listeners
let numTimesInputCalled = 0;
Expand Down