Push up to support Python 3.9.13, bump everything#193
Merged
Conversation
rolambert
approved these changes
Dec 17, 2022
Contributor
rolambert
left a comment
There was a problem hiding this comment.
Looks great, lots of black changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Primary objective - get WebControl working with Python 3.9+ on anything.
Apologies - I ran
blackand there's a lot of reformatting, some of the reformatting I reversed out so that there's less code to review. But even so, I figured some of the blackening can be left in.The Big (and little) Changes
requirements.inin most foldersrequirements.inpip-compile(frompip-tools) to completely rebuild therequirements.txt, pinning everything that gets imported (not just some things), and hopefully the specific versions of everything that will work well together.main.pyReleaseManager.pyso it can handle tags that don't look like floats (look forrelease_tag_mapin the code)f"Your variable here: {v}"formatflash_misaka- just can't be upgradedwgetwithrequests- wget is completely gone as a package (can't be built from source as there is no source anymore)six- just not usedRecommendations
Testing
Yes please