Skip to content

Push up to support Python 3.9.13, bump everything#193

Merged
rolambert merged 1 commit into
masterfrom
bump_everything
Dec 17, 2022
Merged

Push up to support Python 3.9.13, bump everything#193
rolambert merged 1 commit into
masterfrom
bump_everything

Conversation

@aersida
Copy link
Copy Markdown
Contributor

@aersida aersida commented Dec 17, 2022

Description

Primary objective - get WebControl working with Python 3.9+ on anything.

Apologies - I ran black and there's a lot of reformatting, some of the reformatting I reversed out so that there's less code to review. But even so, I figured some of the blackening can be left in.

The Big (and little) Changes

  • Identifying package dependencies in each folder - see requirements.in in most folders
  • Referencing those dependencies in the 'root' requirements.in
  • Using pip-compile (from pip-tools) to completely rebuild the requirements.txt, pinning everything that gets imported (not just some things), and hopefully the specific versions of everything that will work well together.
  • Cleaning up imports in many files, eliminating imports that are unused
  • Fixing that monkey.patch_all problem in main.py
  • Significant rewrite of the virtual environment section of the README
  • Adding a little hack to ReleaseManager.py so it can handle tags that don't look like floats (look for release_tag_map in the code)
  • Some restructuring of certain strings to use the f"Your variable here: {v}" format
  • Dropping flash_misaka - just can't be upgraded
  • Replacing wget with requests - wget is completely gone as a package (can't be built from source as there is no source anymore)
  • Dropping six - just not used

Recommendations

  • Get rid of holeyrequirements.txt - it should be surplus to requirements now (pun intended)
  • Add some info on how to build the executable

Testing

Yes please

@aersida aersida self-assigned this Dec 17, 2022
Copy link
Copy Markdown
Contributor

@rolambert rolambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, lots of black changes.

@rolambert rolambert merged commit fe1f113 into master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants