Skip to content

3.1.5/bug fix vis#101

Merged
hannakoppelaar merged 6 commits into
masterfrom
3.1.5/bug-fix-vis
Mar 6, 2024
Merged

3.1.5/bug fix vis#101
hannakoppelaar merged 6 commits into
masterfrom
3.1.5/bug-fix-vis

Conversation

@leefrank9527
Copy link
Copy Markdown
Contributor

@leefrank9527 leefrank9527 commented Feb 27, 2024

Fixed the issues and improved the performance for visualization:

  1. Removed the max rows limitation from the grid view of visualization. Related to issue Remove the limitaion of the maximum number of rows from inspection view. Remove the limitaion of the maximum number of rows from inspection view. #96

  2. Improved the performance of UI:

  • Did not valid each URLs when put them to the pruning/recrawling candidate page.
  • Fixed the issue of filter for tree views: for the lazy loading tree views, the nodes will be recursively loaded and expanded when filtering from the views. Disabled the auto expanded properties to figure out this issue.
  • Optimized the timer for progress updating: the users can open the page to inspect the progress of modification of havest results. The UI will polling the status of progress periodically. For huge modification, it will take a long time to get the progress data. Sometimes, the previous polling request wasn't finished then the next polling request was triggered. Optimized the process to start the next polling request only after the previous is finished.
  • Cleared the filter of the inspect table after reloadeding the data of the inspect table.

Copy link
Copy Markdown
Contributor

@obrienben obrienben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully

@obrienben
Copy link
Copy Markdown
Contributor

@hannakoppelaar ready for you to review/merge

@hannakoppelaar
Copy link
Copy Markdown
Collaborator

@leefrank9527 It looks good! There's just a minor thing I noticed with respect to the removal of the max rows limitation. The method searchUrlDTOs in NetworkMapClientLocal now has a boolean parameter to disable this limitation. However, in other methods (searchUrl, queryChildrenRecursivelyCrawl and queryChildrenRecursivelyFolder) the code dealing with this limitation is commented out. I think it would make the code easier to understand if we simply got rid of the limitation completely: removing the parameter allowBigDatasets from searchUrlDTOs and deleting the commented out sections.

@leefrank9527
Copy link
Copy Markdown
Contributor Author

searchUrlDTOs

@hannakoppelaar Thanks for the feedback. Accepted the advices and cleared the comments and redundant argument. I've commited the changes to this PR.

@hannakoppelaar hannakoppelaar merged commit 1b038ff into master Mar 6, 2024
@hannakoppelaar hannakoppelaar deleted the 3.1.5/bug-fix-vis branch March 6, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants