Fix the issue of the "patching" status: #170#173
Merged
Conversation
…zing the indexing after all the indexers completed
…ing patching harvest result
…he previous indexer not end
| | | ||
| <a href="#" onclick="javascript: return clickReIndex(<c:out value="${hr.oid}"/>);">Restart Indexing</a> | ||
| </c:when> | ||
| <c:when test="${instance.state eq 'Patching' && wct:xHoursElapsed(6,hr.creationDate)}"> |
Collaborator
There was a problem hiding this comment.
Should this time-out value of 6 (hours) be configurable or at least be defined as a constant somewhere?
Contributor
Author
|
@hannakoppelaar @obrienben : Have updated the PR to made the elapsed hours configurable. Very appreciate if you could have a review of the updates. |
hannakoppelaar
approved these changes
Aug 14, 2025
Collaborator
hannakoppelaar
left a comment
hannakoppelaar
left a comment
There was a problem hiding this comment.
This looks good! The newly added lines of logging (target-instance-results.jsp and Functions.java) may be more useful at debug level than at info level, but I leave that to your judgement.
Contributor
Author
|
@hannakoppelaar Have changed the log level of the newly added lines to debug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue of the "patching" status: