Skip to content

Remove redundant interfaces#64

Merged
obrienben merged 39 commits into
masterfrom
refactor-interfaces-and-impl-classes
Aug 23, 2022
Merged

Remove redundant interfaces#64
obrienben merged 39 commits into
masterfrom
refactor-interfaces-and-impl-classes

Conversation

@hannakoppelaar
Copy link
Copy Markdown
Collaborator

This PR removes most interfaces that have only one implementation. Notable exceptions:

  • Harvester, since this is meant as a crawler API
  • Interfaces in the submit-to-rosetta module, in order to avoid merge conflicts with current development (they're only a handful we can do later)

@obrienben
Copy link
Copy Markdown
Contributor

@leefrank9527 can you please review

@leefrank9527
Copy link
Copy Markdown
Contributor

It simplified the WCT a lot and works well. Agree to merge this branch.

@obrienben obrienben merged commit f5a1c67 into master Aug 23, 2022
@obrienben obrienben deleted the refactor-interfaces-and-impl-classes branch March 18, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants