Skip to content

Sassify!#18

Merged
jtsternberg merged 2 commits intoCMB2:masterfrom
gregrickaby:sassify
Aug 30, 2014
Merged

Sassify!#18
jtsternberg merged 2 commits intoCMB2:masterfrom
gregrickaby:sassify

Conversation

@gregrickaby
Copy link
Copy Markdown
Contributor

I'm going to properly sassify CMB2 👍

@jtsternberg
Copy link
Copy Markdown
Member

No better man for the job! Hate to ask, but is this all tested?

@jtsternberg
Copy link
Copy Markdown
Member

Also, what is the update_submodules task/grunt plugin for? We don't have any submodules in CMB.

@gregrickaby
Copy link
Copy Markdown
Contributor Author

Ah, that's my bad on the submodules. I thought that kept NODE MODULES updated... I'll remove it.

@jtsternberg
Copy link
Copy Markdown
Member

Maybe it does? I don't know. :)

@gregrickaby
Copy link
Copy Markdown
Contributor Author

If by tested you mean, do the styles look the same as CMB2/master? Then the answer is yes.

I tried to keep the CSS identical to what you had. However, I did make some minor color tweaks to keep things consistent (was there really a need for 2 or 3 different "light yellows")?

And it looks like it does keep GIT submodules current, not Node modules. https://github.com/jaubourg/grunt-update-submodules

@jtsternberg
Copy link
Copy Markdown
Member

Yah, that's pretty much what I mean. BUT CMB can be used in the post metaboxes, as a settings page, as user fields, and not to mention the front-end. so If we're going to make big changes to the css, we need to at least look at CMB in all those contexts, as well as viewing each field type. Does that make sense?

@jtsternberg jtsternberg merged commit 3818952 into CMB2:master Aug 30, 2014
@jtsternberg
Copy link
Copy Markdown
Member

💥 Thanks @gregrickaby
selfie-2

@gregrickaby gregrickaby deleted the sassify branch August 30, 2014 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants