feat(migrations): enable recursive discovery in subdirectories#321
Merged
Conversation
…ctories Pass `true` for the `$recursive` parameter in all CLI migration commands so that migrations and seeders organized in subdirectories are automatically discovered. Affected commands: - migrations:run - migrations:fresh - migrations:rollback - migrations:dry-run - migrations:status Also moves legacy broken test fixtures out of App/Database/Migrations into tests/fixtures/ to prevent them from being picked up by recursive discovery. Closes #317
2e97d67 to
b855c18
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #321 +/- ##
============================================
+ Coverage 74.81% 74.88% +0.06%
+ Complexity 3005 2986 -19
============================================
Files 97 97
Lines 9565 9551 -14
============================================
- Hits 7156 7152 -4
+ Misses 2409 2399 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable recursive discovery of migrations and seeders in subdirectories for all CLI migration commands.
Motivation
Organizing migrations by domain in subdirectories (e.g.
Database/Migrations/Master/,Database/Migrations/Lms/) is silently ignored becausediscoverFromPath()is called without$recursive = true. Fixes #317.Changes
truefor the$recursiveparameter indiscoverFromPath()calls across all 5 migration commands:RunMigrationsCommandNewFreshMigrationsCommandRollbackMigrationsCommandDryRunMigrationsCommandMigrationsStatusCommandMultiErr,EmptyRunner,NoConn) fromApp/Database/Migrations/totests/fixtures/Database/Migrations/RecursiveMigrationDiscoveryTestwith 9 test cases covering all commandsHow to Test / Verify
Unit tests: run
phpunit --testsuite "CLI Tests" --filter RecursiveMigrationDiscoveryTestAll 9 tests verify that migrations/seeders placed in subdirectories are discovered and executed correctly.
Breaking Changes and Migration Steps
None. Existing top-level migrations continue to work. Subdirectories that were previously ignored will now be scanned.
Checklist
Related issues
Closes #317