fix(migrations): close database connection after command execution#323
Merged
Conversation
added 2 commits
May 11, 2026 11:22
Add finally block to all migration commands to release the SchemaRunner's database connection after execution. This prevents connection leaks when running multiple commands in sequence (e.g., in test suites).
Test helper methods (initMigrations, dropSchemaTable) also create SchemaRunner instances that hold connections. Resetting the pool after each test ensures all connections are closed regardless of where they were created.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #323 +/- ##
============================================
+ Coverage 74.88% 74.94% +0.06%
- Complexity 2986 2992 +6
============================================
Files 97 97
Lines 9551 9564 +13
============================================
+ Hits 7152 7168 +16
+ Misses 2399 2396 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.