Add config option to pass arguments to GDB#87
Merged
WebFreak001 merged 3 commits intoWebFreak001:masterfrom Dec 11, 2016
Merged
Add config option to pass arguments to GDB#87WebFreak001 merged 3 commits intoWebFreak001:masterfrom
WebFreak001 merged 3 commits intoWebFreak001:masterfrom
Conversation
WebFreak001
requested changes
Dec 11, 2016
Owner
WebFreak001
left a comment
WebFreak001
left a comment
There was a problem hiding this comment.
Looks good but having a more generic name like debugger_args as you suggested would have been better. Also please add that option to lldb and mago-mi too, its exactly the same as for gdb
Mrmaxmeier
force-pushed
the
add-gdbargs-config-option
branch
from
2a55b56 to
5158fbe
Compare
Mrmaxmeier
force-pushed
the
add-gdbargs-config-option
branch
from
5158fbe to
c53c85e
Compare
Mrmaxmeier
commented
Dec 11, 2016
|
|
||
| export class MI2 extends EventEmitter implements IBackend { | ||
| constructor(public application: string, public preargs: string[]) { | ||
| constructor(public application: string, public preargs: string[], public extraargs: string[]) { |
Contributor
Author
There was a problem hiding this comment.
@WebFreak001 I've updated MI2 to accept the additional arguments.
WebFreak001
approved these changes
Dec 11, 2016
Owner
|
ok thanks for the addition. Also thanks for fixing the travis build issue, I wasn't sure what was causing it when I upgraded typescript and wanted to fix it only later because I thought it was a problem with travis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
this PR adds a config option that can be used to pass arguments to GDB.
I'm using it to disable my
.gdbinitfile by settinggdbargsto["-nx", "-x ~/.custom_gdbinit"]because my.gdbinitexpects a real tty.If you think a generic
debugger_argsoption shared between all backends would be better though I'm open to push changes.