Develop triangle #120
Merged
Develop triangle #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mesfinassres hi. recall that, once you are done with your changes, you need to mark me a "Reviewers" (see panel on top-right of screen) |
arcuri82
requested changes
Apr 10, 2025
| public class FormController { | ||
|
|
||
| @GetMapping("/index") | ||
| public String showForm() { |
There was a problem hiding this comment.
why this endpoint? wouldn't make more sense that root "/" is mapped into "index.html"? ie @GetMapping("/") ... return "index.html"?
...s/web/triangle-ssr/src/main/java/com/example/springmvcdocker/SpringMvcDockerApplication.java
Outdated
Show resolved
Hide resolved
|
I have finished making the changes. Sould I go ahead and do the usual git push now? |
|
@mesfinassres yes, you do the push. once everything is fine, and CI is green, then you notify me and I can check the PR update |
|
I had to change the html files which were affected by the change- root "/" is mapped into "index.html". I have pushed these changes as well :) |
|
Hi @arcuri82 Now, everything looks fine and shows green so you can check the PR update. |
arcuri82
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arcuri82
Add triangle classification logic and form processing
Implements form handling in Spring MVC to classify triangles based on side inputs.