Http patch spring drivers #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omursahin
requested review from
arcuri82 and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the new http-patch-spring service into metrics, build scripts, EvoMaster benchmarks, Docker setup, and documentation.
- Add
http-patch-springto statistics tables, CSVs, and dockerized SUT list - Register new Maven modules and include JARs in distribution and EvoMaster external/embedded controllers
- Provide Docker Compose config, Dockerfile, and update README
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| statistics/table_emb.md | Added row for http-patch-spring |
| statistics/data.csv | Added CSV entry for http-patch-spring |
| scripts/dockerize/data/sut.csv | Added SUT line for http-patch-spring |
| scripts/dist.py | Copy new SUT and runner JARs for http-patch-spring |
| jdk_11_maven/em/external/rest/pom.xml | Register http-patch-spring module |
| jdk_11_maven/em/external/rest/http-patch-spring/.../pom.xml | Configure shade plugin for external runner |
| jdk_11_maven/em/external/rest/http-patch-spring/.../ExternalEvoMasterController.java | New External controller for http-patch-spring |
| jdk_11_maven/em/embedded/rest/pom.xml | Register http-patch-spring module |
| jdk_11_maven/em/embedded/rest/http-patch-spring/.../pom.xml | POM for embedded benchmark JAR |
| jdk_11_maven/em/embedded/rest/http-patch-spring/.../EmbeddedEvoMasterController.java | New Embedded controller for http-patch-spring |
| jdk_11_maven/cs/rest/pom.xml | Register http-patch-spring in cs/rest |
| jdk_11_maven/cs/rest/http-patch-spring/pom.xml | Added SpringDoc dependency and repackage config |
| dockerfiles/http-patch-spring.yaml | Added Docker Compose service |
| dockerfiles/http-patch-spring.dockerfile | Dockerfile for http-patch-spring SUT |
| README.md | Increment count, add HTTP Patch Spring entry |
| <transformer | ||
| implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer"> | ||
| <manifestEntries> | ||
| <Main-Class>em.external.com.pfa.app.ExternalEvoMasterController |
There was a problem hiding this comment.
The Main-Class manifest entry refers to the wrong package path. It should be "em.external.http.patch.spring.ExternalEvoMasterController" to match the actual class.
Suggested change
| <Main-Class>em.external.com.pfa.app.ExternalEvoMasterController | |
| <Main-Class>em.external.http.patch.spring.ExternalEvoMasterController |
| } | ||
|
|
||
| @Override | ||
| public List<DbSpecification> getDbSpecifications() { |
There was a problem hiding this comment.
The dbSpecification field is never initialized, leading to a null return. Consider initializing it (e.g., an empty list) or wiring actual DB specs to avoid NPEs during test runs.
|
|
||
| @Override | ||
| public List<AuthenticationDto> getInfoForAuthentication() { | ||
| return null; |
There was a problem hiding this comment.
Returning null for authentication info can cause issues; prefer returning an empty list when no auth is needed.
Suggested change
| return null; | |
| return List.of(); |
Contributor
|
@omursahin I see comments from Copilot here... is it something you activated? or is it GitHub adding it without asking? |
arcuri82
requested changes
Jul 9, 2025
| <transformer | ||
| implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer"> | ||
| <manifestEntries> | ||
| <Main-Class>em.external.com.pfa.app.ExternalEvoMasterController |
arcuri82
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.