feat(newTour): check user privileges before role-based fallback#215
Merged
Conversation
The newTour handler now checks `user.privileges.includes('tour:create')`
when the user has a non-empty privileges array, and falls back to the
existing `userRoles`-based check when privileges is empty.
- Existing users (no privileges set) keep authorizing via userType — no
behavior change for any current human user.
- New admin-managed users (created via the forthcoming JaMmusic admin UI)
authorize via per-user privileges.
- Extracted the auth check into `utils.assertCanCreateTour` to keep
newTour under the cognitive-complexity ceiling.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newTourhandler to checkuser.privileges.includes('tour:create')first, with a fallback to the existinguserRoles-based check whenprivilegesis empty.utils.assertCanCreateTourto keepnewTourunder the cognitive-complexity ceiling.privilegesfield on User and the admin routes that populate it.Backward compatibility
privilegesset; they continue authorizing viauserTypeexactly as before.privilegesarrays.editTour,removeTour, etc.) are unchanged — they still gate purely onuserType. Future PRs migrate them as needed.Test plan
npm run test:lint)npm run typecheck)npm run test:unit), including two new tests for the capability-allowed and capability-missing pathsprivileges: ['tour:create'], mint a token, transmitnewTour, confirm gig is created🤖 Generated with Claude Code