Skip to content

Await driver.quit #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 22, 2025
Merged

Await driver.quit #209

merged 9 commits into from
Oct 22, 2025

Conversation

@camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Oct 17, 2025 •
edited
Loading

  • Use await "driver.quit()" to properly await the browser and driver shutdown.
  • Print safaridriver logs in case of failures (to be removed once we're stable again)

@netlify
Copy link

netlify bot commented Oct 17, 2025 •
edited
Loading

✅ Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 4b0f46c
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68f8f9cb21a67100083aa33d
😎 Deploy Preview https://deploy-preview-209--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni changed the title Debug safari failures Force enable safaridriver Oct 17, 2025
@camillobruni camillobruni marked this pull request as draft October 22, 2025 10:02
@camillobruni camillobruni changed the title Force enable safaridriver Await driver.quite to fix Safari crashes Oct 22, 2025
@camillobruni camillobruni marked this pull request as ready for review October 22, 2025 12:38
@camillobruni camillobruni force-pushed the 2025-10-17_safaridriver_fix branch from 16edc11 to d953c52 Compare October 22, 2025 12:38
@camillobruni camillobruni requested a review from danleh October 22, 2025 12:38
@camillobruni camillobruni changed the title Await driver.quite to fix Safari crashes Await driver.quite Oct 22, 2025
@camillobruni camillobruni changed the title Await driver.quite Await driver.quit Oct 22, 2025
danleh
danleh approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice if that fixes the Safari CI issue! LGTM with question/nit.

@camillobruni camillobruni merged commit 25363ce into WebKit:main Oct 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danleh danleh danleh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camillobruni @danleh