-
Notifications
You must be signed in to change notification settings - Fork 19
Add explicit version checks #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
camillobruni
commented
Oct 21, 2025
- Add utils/version-check.mjs to warn against invalid nodejs versions
- Add license headers to newly added files, utils and test files
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the version checks, is there a reason to not use the more builtin checking by adding a .npmrc file with engine-strict=true? AFAIU node already warns if the versions in engines are not fulfilled; with the additional config file it should error out (not tested, just read that at https://stackoverflow.com/questions/29349684/how-can-i-specify-the-required-node-js-version-in-package-json)
Yay to proper license headers :)
|
I've tried the npmrc approach and I didn't work locally :/. |
|
Ah well, let's go with the explicit version check script then (unless Keith or someone else has an idea). |
kmiller68
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. I don't know a better way to test node's version either. We can always remove this if we find a better way to test.