Skip to content

Conversation

@camillobruni
Copy link
Contributor

Use the same label formatting for "Total" metrics as for line items.

BEFORE:

Total:
First-Score                                    526.74 pts
Worst-Score                                    496.83 pts
Average-Score                                  565.33 pts
First-Time                                       9.49 ms 
Worst-Time                                      10.06 ms 
Average-Time                                     8.84 ms 

Total-Score                                    528.89 pts
Total-Time                                     526.07 ms 

AFTER:

Total:
Total First-Score                              531.83 pts
Total Worst-Score                              503.43 pts
Total Average-Score                            565.33 pts
Total First-Time                                 9.40 ms 
Total Worst-Time                                 9.93 ms 
Total Average-Time                               8.84 ms 

Total Score                                    532.93 pts
Total Time                                     523.89 ms 

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit cb536ec
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68f8908bccbffd0008121b1f
😎 Deploy Preview https://deploy-preview-213--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni requested a review from danleh October 22, 2025 08:08
Copy link
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any particular reason why there is a dash between e.g. First-Time but not between Total First? If it's just legacy because of existing parsing/scripts, that's fine as well, just wanted to know.

@camillobruni
Copy link
Contributor Author

This matches what we have for workloads

Running json-parse-inspector:
json-parse-inspector First-Score               294.10 pts
json-parse-inspector Worst-Score               238.45 pts
json-parse-inspector Average-Score             304.39 pts
json-parse-inspector Score                     277.40 pts
json-parse-inspector First-Time                 17.00 ms 
json-parse-inspector Worst-Time                 20.97 ms 
json-parse-inspector Average-Time               16.43 ms 
json-parse-inspector Wall-Time                 409.53 ms 
json-parse-inspector Total-Time                 54.40 ms 

$WORKLOAD_NAME $METRIC_NAME

We could do Total Total-Time though?

@danleh
Copy link
Contributor

danleh commented Oct 22, 2025

Ah, makes sense. All good then, no need to change from my side.

@camillobruni camillobruni merged commit 3db87be into WebKit:main Oct 22, 2025
9 of 10 checks passed
@camillobruni camillobruni deleted the 2025-10-22_total_times branch October 22, 2025 12:27
for (let [category, scores] of categoryScores) {
console.log(
shellFriendlyLabel(`${category}-Score`),
shellFriendlyLabel(`Total ${category}-Score`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a total though? I feel like "Geomean" would be a more accurate label. I would assume this is the sum of all score in this category

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is for the overall report, I see now. Ignore me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants