-
Notifications
You must be signed in to change notification settings - Fork 18
More consistent total score printing #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any particular reason why there is a dash between e.g. First-Time but not between Total First? If it's just legacy because of existing parsing/scripts, that's fine as well, just wanted to know.
|
This matches what we have for workloads
We could do |
|
Ah, makes sense. All good then, no need to change from my side. |
| for (let [category, scores] of categoryScores) { | ||
| console.log( | ||
| shellFriendlyLabel(`${category}-Score`), | ||
| shellFriendlyLabel(`Total ${category}-Score`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really a total though? I feel like "Geomean" would be a more accurate label. I would assume this is the sum of all score in this category
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is for the overall report, I see now. Ignore me.
Use the same label formatting for "Total" metrics as for line items.
BEFORE:
AFTER: