Skip to content

More consistent total score printing #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

More consistent total score printing #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions JetStreamDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,17 +332,17 @@ class Driver {
console.log("Total:");
for (let [category, scores] of categoryScores) {
console.log(
shellFriendlyLabel(`${category}-Score`),
shellFriendlyLabel(`Total ${category}-Score`),
Copy link
Contributor

@kmiller68 kmiller68 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a total though? I feel like "Geomean" would be a more accurate label. I would assume this is the sum of all score in this category

Copy link
Contributor

@kmiller68 kmiller68 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is for the overall report, I see now. Ignore me.

shellFriendlyScore(geomeanScore(scores)));
}
for (let [category, times] of categoryTimes) {
console.log(
shellFriendlyLabel(`${category}-Time`),
shellFriendlyLabel(`Total ${category}-Time`),
shellFriendlyDuration(geomeanScore(times)));
}
console.log("");
console.log(shellFriendlyLabel("Total-Score"), shellFriendlyScore(totalScore));
console.log(shellFriendlyLabel("Total-Time"), shellFriendlyDuration(totalTime));
console.log(shellFriendlyLabel("Total Score"), shellFriendlyScore(totalScore));
console.log(shellFriendlyLabel("Total Time"), shellFriendlyDuration(totalTime));
console.log("");
}

Expand Down
Loading