Skip to content

Commit 19defa4

Browse files
committed
[iOS Firefox] Remove quirk added in 300584@main
https://bugs.webkit.org/show_bug.cgi?id=303320 rdar://165624257 Reviewed by Andy Estes. Remove the quirk now that the bug in Firefox has been fixes. * Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h: * Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.mm: (WTF::computeSDKAlignedBehaviors): (WTF::IOSApplication::isFirefox): Deleted. (WTF::IOSApplication::isFirefoxFocus): Deleted. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::initializeMediaSession): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::determineRelevantQuirks): (WebCore::Quirks::requirePageVisibilityToPlayAudioQuirk const): Deleted. * Source/WebCore/page/Quirks.h: * Source/WebCore/page/QuirksData.h: Canonical link: https://commits.webkit.org/303778@main
1 parent edcfd01 commit 19defa4

6 files changed

Lines changed: 2 additions & 39 deletions

File tree

Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ enum class SDKAlignedBehavior {
7474
ModernCompabilityModeByDefault,
7575
MutationEventsDisabledByDefault,
7676
NavigationActionSourceFrameNonNull,
77-
AllowBackgroundAudioPlayback,
7877
NoClientCertificateLookup,
7978
NoExpandoIndexedPropertiesOnWindow,
8079
NoPokerBrosBuiltInTagQuirk,
@@ -207,8 +206,6 @@ WTF_EXPORT_PRIVATE bool isMobileStore();
207206
WTF_EXPORT_PRIVATE bool isUNIQLOApp();
208207
WTF_EXPORT_PRIVATE bool isDOFUSTouch();
209208
WTF_EXPORT_PRIVATE bool isMyRideK12();
210-
WTF_EXPORT_PRIVATE bool isFirefox();
211-
WTF_EXPORT_PRIVATE bool isFirefoxFocus();
212209

213210
} // IOSApplication
214211

Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.mm

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -238,10 +238,8 @@ static SDKAlignedBehaviors computeSDKAlignedBehaviors()
238238
if (linkedBefore(dyld_2024_SU_F_os_versions, DYLD_IOS_VERSION_18_5, DYLD_MACOSX_VERSION_15_5))
239239
disableBehavior(SDKAlignedBehavior::NavigationActionSourceFrameNonNull);
240240

241-
if (linkedBefore(dyld_2025_SU_B_os_versions, DYLD_IOS_VERSION_26_1, DYLD_MACOSX_VERSION_26_1)) {
242-
disableBehavior(SDKAlignedBehavior::AllowBackgroundAudioPlayback);
241+
if (linkedBefore(dyld_2025_SU_B_os_versions, DYLD_IOS_VERSION_26_1, DYLD_MACOSX_VERSION_26_1))
243242
disableBehavior(SDKAlignedBehavior::GetBoundingClientRectZoomed);
244-
}
245243

246244
disableAdditionalSDKAlignedBehaviors(behaviors);
247245

@@ -605,18 +603,6 @@ static bool applicationBundleIsEqualTo(const String& bundleIdentifierString)
605603
return isMyRideK12;
606604
}
607605

608-
bool IOSApplication::isFirefox()
609-
{
610-
static bool isFirefox = applicationBundleIsEqualTo("org.mozilla.ios.Firefox"_s);
611-
return isFirefox;
612-
}
613-
614-
bool IOSApplication::isFirefoxFocus()
615-
{
616-
static bool isFirefoxFocus = applicationBundleIsEqualTo("org.mozilla.ios.Focus"_s);
617-
return isFirefoxFocus;
618-
}
619-
620606
bool IOSApplication::isHimalaya()
621607
{
622608
static bool isHimalayaApp = applicationBundleIsEqualTo("com.gemd.iting"_s);

Source/WebCore/html/HTMLMediaElement.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ void HTMLMediaElement::initializeMediaSession()
705705
if (document->settings().invisibleAutoplayNotPermitted())
706706
mediaSession->addBehaviorRestriction(MediaElementSession::InvisibleAutoplayNotPermitted);
707707

708-
if (document->settings().requiresPageVisibilityToPlayAudio() || document->quirks().requirePageVisibilityToPlayAudioQuirk())
708+
if (document->settings().requiresPageVisibilityToPlayAudio())
709709
mediaSession->addBehaviorRestriction(MediaElementSession::RequirePageVisibilityToPlayAudio);
710710

711711
if (document->ownerElement() || !document->isMediaDocument()) {

Source/WebCore/page/Quirks.cpp

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1711,19 +1711,6 @@ bool Quirks::shouldFlipScreenDimensions() const
17111711
#endif
17121712
}
17131713

1714-
// Firefox and Firefox Focus (rdar://159977164)
1715-
bool Quirks::requirePageVisibilityToPlayAudioQuirk() const
1716-
{
1717-
#if PLATFORM(IOS_FAMILY)
1718-
if (!needsQuirks()) [[unlikely]]
1719-
return false;
1720-
1721-
return m_quirksData.quirkIsEnabled(QuirksData::SiteSpecificQuirk::RequirePageVisibilityToPlayAudioQuirk);
1722-
#else
1723-
return false;
1724-
#endif
1725-
}
1726-
17271714
// This section is dedicated to UA override for iPad. iPads (but iPad Mini) are sending a desktop user agent
17281715
// to websites. In some cases, the website breaks in some ways, not expecting a touch interface for the website.
17291716
// Controls not active or too small, form factor, etc. In this case it is better to send the iPad Mini UA.
@@ -3425,14 +3412,11 @@ void Quirks::determineRelevantQuirks()
34253412
#if PLATFORM(IOS_FAMILY)
34263413
static const bool shouldDisableLazyIframeLoadingQuirk = !linkedOnOrAfterSDKWithBehavior(SDKAlignedBehavior::NoUNIQLOLazyIframeLoadingQuirk) && WTF::IOSApplication::isUNIQLOApp();
34273414
static const bool needsResettingTransitionCancelsRunningTransitionQuirk = !linkedOnOrAfterSDKWithBehavior(SDKAlignedBehavior::ResettingTransitionCancelsRunningTransitionQuirk) && WTF::IOSApplication::isDOFUSTouch();
3428-
static const bool requirePageVisibilityToPlayAudioQuirk = (WTF::IOSApplication::isFirefox() || WTF::IOSApplication::isFirefoxFocus()) && !linkedOnOrAfterSDKWithBehavior(SDKAlignedBehavior::AllowBackgroundAudioPlayback);
34293415

34303416
m_quirksData.setQuirkState(QuirksData::SiteSpecificQuirk::ShouldDisableLazyIframeLoadingQuirk, shouldDisableLazyIframeLoadingQuirk);
34313417

34323418
// DOFUS Touch app (rdar://112679186)
34333419
m_quirksData.setQuirkState(QuirksData::SiteSpecificQuirk::NeedsResettingTransitionCancelsRunningTransitionQuirk, needsResettingTransitionCancelsRunningTransitionQuirk);
3434-
3435-
m_quirksData.setQuirkState(QuirksData::SiteSpecificQuirk::RequirePageVisibilityToPlayAudioQuirk, requirePageVisibilityToPlayAudioQuirk);
34363420
#endif
34373421

34383422
#if PLATFORM(MAC)

Source/WebCore/page/Quirks.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ class Quirks {
9191

9292
bool shouldPreventOrientationMediaQueryFromEvaluatingToLandscape() const;
9393
bool shouldFlipScreenDimensions() const;
94-
bool requirePageVisibilityToPlayAudioQuirk() const;
9594

9695
WEBCORE_EXPORT bool shouldDispatchSyntheticMouseEventsWhenModifyingSelection() const;
9796
WEBCORE_EXPORT bool shouldSuppressAutocorrectionAndAutocapitalizationInHiddenEditableAreas() const;

Source/WebCore/page/QuirksData.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,6 @@ struct QuirksData {
125125
#if PLATFORM(MAC)
126126
NeedsZomatoEmailLoginLabelQuirk,
127127
#endif
128-
#if PLATFORM(IOS_FAMILY)
129-
RequirePageVisibilityToPlayAudioQuirk,
130-
#endif
131128
#if ENABLE(VIDEO_PRESENTATION_MODE)
132129
RequiresUserGestureToLoadInPictureInPictureQuirk,
133130
RequiresUserGestureToPauseInPictureInPictureQuirk,

0 commit comments

Comments
 (0)