Skip to content

Commit f3607e1

Browse files
committed
[iOS] fast/mediasession/metadata/artworkdownload.html is a flaky text failure
rdar://175302325 https://bugs.webkit.org/show_bug.cgi?id=312949 Reviewed by Anne van Kesteren. The first promise_test calls internals.loadArtworkImage() which returns a VideoFrame. The test inspects codedWidth and codedHeight but never calls data.close(). Thus, WebKit emits a console warning when a VideoFrame is garbage-collected without being closed, which causes a text mismatch. Per the WebCodecs spec, VideoFrame objects should be explicitly closed to release underlying media resources. Files changed (1): - artworkdownload.html: Add data.close to explicitly release VideoFrame resources. * LayoutTests/fast/mediasession/metadata/artworkdownload.html: * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/311886@main
1 parent 1b1e4d0 commit f3607e1

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

LayoutTests/fast/mediasession/metadata/artworkdownload.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
return internals.loadArtworkImage(IMAGE_SRC).then((data) => {
1414
assert_equals(data.codedWidth, 16);
1515
assert_equals(data.codedHeight, 16);
16+
data.close();
1617
});
1718
}, "ensure loading artwork image method operates properly");
1819

LayoutTests/platform/ios/TestExpectations

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8523,8 +8523,6 @@ webkit.org/b/312496 fast/forms/select/base/select-pagedown-pageup-vertical.html
85238523

85248524
webkit.org/b/312499 imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/form.html [ Pass Failure ]
85258525

8526-
webkit.org/b/312949 fast/mediasession/metadata/artworkdownload.html [ Pass Failure ]
8527-
85288526
webkit.org/b/309173 imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/modulepreload-referrerpolicy.html [ Pass Failure ]
85298527

85308528
webkit.org/b/309019 imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html?include=root-scrollBy-auto [ Pass Failure ]

0 commit comments

Comments
 (0)