Skip to content

Conversation

@magomez
Copy link
Contributor

@magomez magomez commented Feb 14, 2023

38f8a72

[WPE] Build broken with external holepunch enabled
https://bugs.webkit.org/show_bug.cgi?id=252236

Reviewed by Xabier Rodriguez-Calvar.

Rename setSize() method to sePresentationSize() and use ASCIILiteral instances
to initialize the mime types instead of using char*.

* Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:
(WebCore::mimeTypeCache):
* Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h:

Canonical link: https://commits.webkit.org/260251@main

2129d97

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 🧪 api-mac 🧪 gtk-wk2
🧪 api-ios ✅ 🧪 mac-wk1 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@magomez magomez self-assigned this Feb 14, 2023
@magomez magomez added the WPE WebKit WebKit WPE component label Feb 14, 2023
@magomez magomez requested a review from calvaris February 14, 2023 10:18
@magomez magomez added the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2023
https://bugs.webkit.org/show_bug.cgi?id=252236

Reviewed by Xabier Rodriguez-Calvar.

Rename setSize() method to sePresentationSize() and use ASCIILiteral instances
to initialize the mime types instead of using char*.

* Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:
(WebCore::mimeTypeCache):
* Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h:

Canonical link: https://commits.webkit.org/260251@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260251@main (38f8a72): https://commits.webkit.org/260251@main

Reviewed commits have been landed. Closing PR #10082 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 38f8a72 into WebKit:main Feb 14, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2023
@magomez magomez deleted the eng/252236 branch October 14, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants