Skip to content

Remove _webkit_fixedCarbonPOSIXPath #10577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Apr 1, 2023
Merged

Remove _webkit_fixedCarbonPOSIXPath #10577

webkit-commit-queue merged 1 commit into from
Apr 1, 2023

Conversation

@AZero13
Copy link
Contributor

@AZero13 AZero13 commented Feb 23, 2023 •
edited by webkit-early-warning-system
Loading

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 23, 2023 •
edited
Loading

EWS run on current version of this PR (hash c0d6737)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 1, 2023
@Ahmad-S792
Copy link
Contributor

Ahmad-S792 commented Mar 31, 2023

@aproskuryakov - Can you help who can review this PR? Thanks in advance!

@aproskuryakov aproskuryakov added the merge-queue Applied to send a pull request to merge-queue label Apr 1, 2023
@AZero13 @aproskuryakov
Remove _webkit_fixedCarbonPOSIXPath
27185f9 
https://bugs.webkit.org/show_bug.cgi?id=252818

Reviewed by Alexey Proskuryakov.

Safari 8 is long gone and no longer supported. We can remove this
function/method.

Canonical link: https://commits.webkit.org/262457@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-_webkit_fixedCarbonPOSIXPath-from-WebKit branch from c0d6737 to 27185f9 Compare April 1, 2023 01:05
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Apr 1, 2023

Committed 262457@main (27185f9): https://commits.webkit.org/262457@main

Reviewed commits have been landed. Closing PR #10577 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 1, 2023
@webkit-commit-queue webkit-commit-queue merged commit 27185f9 into WebKit:main Apr 1, 2023
@AZero13 AZero13 deleted the eng/Remove-_webkit_fixedCarbonPOSIXPath-from-WebKit branch April 2, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aproskuryakov aproskuryakov aproskuryakov approved these changes

Assignees

@AZero13 AZero13

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AZero13 @webkit-early-warning-system @Ahmad-S792 @webkit-commit-queue @aproskuryakov