[UI-side compositing] fast/canvas/webgl/lose-context-on-timeout.html fails#11166
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 8, 2023
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 3dea854) Details
|
3dea854 to
1b2013c
Compare
Collaborator
|
EWS run on current version of this PR (hash 1b2013c) Details
|
smfr
approved these changes
Mar 7, 2023
…fails https://bugs.webkit.org/show_bug.cgi?id=253496 rdar://106115219 Reviewed by Simon Fraser. The simulated timeout mechanism does not at the moment apply immediately because it posts work from GPUP RemoteGraphicsContextGL work queue to main thread. Take this into account in lose-context-on-timeout.html by ensuring that the call to be timed out is called potentially multiple times. Also fix other test problems related to lose-context-on-timeout.html and the async variant: - Use a method that is more likely not cached caller side - Register the WebGL context lost handler before the context loss has chance of being invoked - Use test metadata to always select GPUP WebGL as the testing variant. This way the testing skips can be removed from the TestExpectations and the test is run by default. * LayoutTests/TestExpectations: * LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async-expected.txt: * LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async.html: * LayoutTests/fast/canvas/webgl/lose-context-on-timeout-expected.txt: * LayoutTests/fast/canvas/webgl/lose-context-on-timeout.html: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/261360@main
1b2013c to
28a6eb5
Compare
Collaborator
|
Committed 261360@main (28a6eb5): https://commits.webkit.org/261360@main Reviewed commits have been landed. Closing PR #11166 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
28a6eb5
1b2013c
🧪 wpe-wk2