Skip to content

[UI-side compositing] fast/canvas/webgl/lose-context-on-timeout.html fails#11166

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
kkinnunen-apple:gpup-lose-context-on-timeout-1
Mar 8, 2023
Merged

[UI-side compositing] fast/canvas/webgl/lose-context-on-timeout.html fails#11166
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
kkinnunen-apple:gpup-lose-context-on-timeout-1

Conversation

@kkinnunen-apple
Copy link
Copy Markdown
Contributor

@kkinnunen-apple kkinnunen-apple commented Mar 7, 2023

28a6eb5

[UI-side compositing] fast/canvas/webgl/lose-context-on-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=253496
rdar://106115219

Reviewed by Simon Fraser.

The simulated timeout mechanism does not at the moment apply immediately
because it posts work from GPUP RemoteGraphicsContextGL work queue to
main thread. Take this into account in lose-context-on-timeout.html
by ensuring that the call to be timed out is called potentially
multiple times.

Also fix other test problems related to lose-context-on-timeout.html
and the async variant:
- Use a method that is more likely not cached caller side
- Register the WebGL context lost handler before the context loss has
  chance of being invoked
- Use test metadata to always select GPUP WebGL as the testing variant.
  This way the testing skips can be removed from the TestExpectations
  and the test is run by default.

* LayoutTests/TestExpectations:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async-expected.txt:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async.html:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout-expected.txt:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/261360@main

1b2013c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch 💥 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@kkinnunen-apple kkinnunen-apple self-assigned this Mar 7, 2023
@kkinnunen-apple kkinnunen-apple added the WebGL Bugs in WebKit’s implementation of the WebGL standard. label Mar 7, 2023
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Mar 7, 2023

@kkinnunen-apple kkinnunen-apple force-pushed the gpup-lose-context-on-timeout-1 branch from 3dea854 to 1b2013c Compare March 7, 2023 14:38
@kkinnunen-apple kkinnunen-apple requested review from djg and grorg March 7, 2023 14:38
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Mar 7, 2023

@kkinnunen-apple kkinnunen-apple added the merge-queue Applied to send a pull request to merge-queue label Mar 8, 2023
…fails

https://bugs.webkit.org/show_bug.cgi?id=253496
rdar://106115219

Reviewed by Simon Fraser.

The simulated timeout mechanism does not at the moment apply immediately
because it posts work from GPUP RemoteGraphicsContextGL work queue to
main thread. Take this into account in lose-context-on-timeout.html
by ensuring that the call to be timed out is called potentially
multiple times.

Also fix other test problems related to lose-context-on-timeout.html
and the async variant:
- Use a method that is more likely not cached caller side
- Register the WebGL context lost handler before the context loss has
  chance of being invoked
- Use test metadata to always select GPUP WebGL as the testing variant.
  This way the testing skips can be removed from the TestExpectations
  and the test is run by default.

* LayoutTests/TestExpectations:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async-expected.txt:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async.html:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout-expected.txt:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/261360@main
@webkit-commit-queue webkit-commit-queue force-pushed the gpup-lose-context-on-timeout-1 branch from 1b2013c to 28a6eb5 Compare March 8, 2023 06:28
@webkit-commit-queue webkit-commit-queue merged commit 28a6eb5 into WebKit:main Mar 8, 2023
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 261360@main (28a6eb5): https://commits.webkit.org/261360@main

Reviewed commits have been landed. Closing PR #11166 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGL Bugs in WebKit’s implementation of the WebGL standard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants