Use move semantics for SharedMemory::Handle #12995

donny-dont · 2023-04-20T22:52:49Z

`a6579e4`

Use move semantics for SharedMemory::Handle
https://bugs.webkit.org/show_bug.cgi?id=255745

Reviewed by Kimmo Kinnunen.

Use move semantics to signify ownership of the `SharedMemory::Handle`.

* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
* Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
* Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h:
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
* Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp:
* Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.h:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
* Source/WebKit/Platform/IPC/SharedBufferReference.cpp:
* Source/WebKit/Platform/IPC/StreamServerConnectionBuffer.h:
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
* Source/WebKit/Platform/SharedMemory.h:
* Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:
* Source/WebKit/Platform/unix/SharedMemoryUnix.cpp:
* Source/WebKit/Platform/win/SharedMemoryWin.cpp:
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
* Source/WebKit/Shared/ShareableBitmap.cpp:
* Source/WebKit/Shared/ShareableResource.cpp:
* Source/WebKit/Shared/WebCompiledContentRuleListData.cpp:
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
* Source/WebKit/Shared/WebHitTestResultData.cpp:
* Source/WebKit/Shared/WebHitTestResultData.h:
* Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
* Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
* Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
* Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h:
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
* Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
* Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h:
* Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp:
* Source/WebKit/WebProcess/Storage/WebSWClientConnection.h:
* Source/WebKit/WebProcess/Storage/WebSWOriginTable.cpp:
* Source/WebKit/WebProcess/Storage/WebSWOriginTable.h:
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
* Source/WebKit/WebProcess/WebPage/VisitedLinkTableController.cpp:
* Source/WebKit/WebProcess/WebPage/VisitedLinkTableController.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
* Source/WebKit/WebProcess/WebPage/WebPage.h:

Canonical link: https://commits.webkit.org/263809@main

1b27815

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt		✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-20T22:53:01Z

EWS run on previous version of this PR (hash 95eab95)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	~~🛠 mac~~	❌ 🛠 wpe	⏳ 🛠 wincairo
	❌ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🧪 api-gtk
	❌ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-04-20T23:12:12Z

EWS run on previous version of this PR (hash 07f99b2)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	~~🛠 mac~~	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	~~🧪 mac-wk2~~	⏳ 🧪 api-gtk
	❌ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	❌ 🛠 watch
	❌ 🛠 watch-sim

cdumez · 2023-04-20T23:14:33Z

Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp

Isn't SharedMemory::Handle essentially just an integer (or 2 with the size)? If so, it doesn't seem like there would be much benefit to moving it around?

This patch started when I asked @kkinnunen-apple about what the behavior of SharedMemory::map was supposed to be with regards to the handle passed in. The behavior was not consistent between the different backend implementations, Win, Unix, Cocoa. I found this out when enabling GPU Process on PlayStation where the Unix variant of SharedMemory::createHandle asserted but the Windows one was fine.

So @kkinnunen-apple expressed a plan to refactor SharedMemory::map to take a Handle&& but wasn't available to work on it till later. Since I was broken I took a stab at this. I THINK I replicated their plan but I'll let them chime in.

👍🏻 This is more about transferring ownership when optimizing copies. Seems fine.

webkit-early-warning-system · 2023-04-20T23:43:42Z

EWS run on previous version of this PR (hash e098478)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch
	❌ 🛠 watch-sim

kkinnunen-apple

Great start! Still a bit of work to do, though! :)

kkinnunen-apple · 2023-04-21T05:53:52Z

Source/WebKit/Platform/SharedMemory.h

Remember to remove the "mutable" from " m_handle;" declarations above.

kkinnunen-apple · 2023-04-21T06:00:46Z

Source/WebKit/Shared/ShareableBitmap.cpp

Unfortunately this indicates a contagiousness of the change:
All the types that contain SharedMemoryHandle must now support move semantics also.
So before on Cocoa, SharedMemory::map did not mutate the handle. This meant that the ShareableBitmapHandle handle here would stay intact and operational after ShareableBitmap::create(). Now, after your change, the m_handle is moved away and the ShareableBitmapHandle is rendered inoperable.
It is unknown if any code relied on the ShareableBitmapHandle staying operable.

Thus to prove correctness, the approach would be to first make ShareableBitmapHandle movable, land that, and then continue with this patch.

RefPtr<ShareableBitmap> ShareableBitmap::create(const ShareableBitmapHandle& handle, SharedMemory::Protection protection)
->
RefPtr<ShareableBitmap> ShareableBitmap::create(ShareableBitmapHandle&& handle, SharedMemory::Protection protection)

kkinnunen-apple · 2023-04-21T06:03:06Z

Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp

This lacks WTFMove (the compiler will tell you this, though)

kkinnunen-apple · 2023-04-21T06:09:26Z

Source/WebKit/Platform/IPC/StreamServerConnectionBuffer.h

So here StreamServerConnectionBuffer::Handle is a function where the author already thought that handles have to have move semantics as the consumption operation, and thus already declared Handle as && so you don't need to do the same thing as with ShareableBitmap/ShareableResource. 😉

webkit-early-warning-system · 2023-04-25T21:23:21Z

EWS run on previous version of this PR (hash d953dee)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-04-25T22:04:56Z

EWS run on previous version of this PR (hash ab14f05)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	❌ 🛠 ios-sim	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2023-04-25T22:26:57Z

EWS run on previous version of this PR (hash aada203)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-05-04T20:35:25Z

EWS run on previous version of this PR (hash c52ac16)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🧪 api-gtk~~
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-05-04T21:45:09Z

EWS run on previous version of this PR (hash b987200)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	❌ 🧪 api-mac	✅ 🛠 gtk
⏳ 🧪 webkitpy	~~🧪 ios-wk2-wpt~~	❌ 🧪 mac-wk1	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	❌ 🧪 mac-wk2	⏳ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-05-04T22:03:59Z

EWS run on previous version of this PR (hash 9f11c7c)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-05-05T00:27:18Z

EWS run on previous version of this PR (hash 0af1cec)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt		✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-05-05T20:17:56Z

EWS run on previous version of this PR (hash 85b409b)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt		✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-05-08T04:54:25Z

EWS run on current version of this PR (hash 1b27815)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	🛠 ios	🛠 mac	🛠 wpe	🛠 wincairo
	🛠 ios-sim	🛠 mac-AS-debug	🧪 wpe-wk2
🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🛠 gtk
	🧪 ios-wk2-wpt	🧪 mac-wk1	🧪 gtk-wk2
	🧪 api-ios	🧪 mac-wk2	🧪 api-gtk
	🛠 tv	🧪 mac-AS-debug-wk2
	🛠 tv-sim	🧪 mac-wk2-stress
	🛠 watch
	🛠 watch-sim

webkit-early-warning-system · 2023-05-08T04:54:26Z

EWS run on current version of this PR (hash 1b27815)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt		✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=255745 Reviewed by Kimmo Kinnunen. Use move semantics to signify ownership of the `SharedMemory::Handle`. * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp: * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: * Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp: * Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h: * Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h: * Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm: * Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp: * Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.h: * Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp: * Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h: * Source/WebKit/Platform/IPC/SharedBufferReference.cpp: * Source/WebKit/Platform/IPC/StreamServerConnectionBuffer.h: * Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp: * Source/WebKit/Platform/SharedMemory.h: * Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp: * Source/WebKit/Platform/unix/SharedMemoryUnix.cpp: * Source/WebKit/Platform/win/SharedMemoryWin.cpp: * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: * Source/WebKit/Shared/ShareableBitmap.cpp: * Source/WebKit/Shared/ShareableResource.cpp: * Source/WebKit/Shared/WebCompiledContentRuleListData.cpp: * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: * Source/WebKit/Shared/WebHitTestResultData.cpp: * Source/WebKit/Shared/WebHitTestResultData.h: * Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm: * Source/WebKit/UIProcess/mac/WebPageProxyMac.mm: * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp: * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp: * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp: * Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp: * Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp: * Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h: * Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp: * Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp: * Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h: * Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp: * Source/WebKit/WebProcess/Storage/WebSWClientConnection.h: * Source/WebKit/WebProcess/Storage/WebSWOriginTable.cpp: * Source/WebKit/WebProcess/Storage/WebSWOriginTable.h: * Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp: * Source/WebKit/WebProcess/WebPage/VisitedLinkTableController.cpp: * Source/WebKit/WebProcess/WebPage/VisitedLinkTableController.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: * Source/WebKit/WebProcess/WebPage/WebPage.h: Canonical link: https://commits.webkit.org/263809@main

webkit-commit-queue · 2023-05-08T18:35:03Z

Committed 263809@main (a6579e4): https://commits.webkit.org/263809@main

Reviewed commits have been landed. Closing PR #12995 and removing active labels.

donny-dont requested review from a team and cdumez as code owners April 20, 2023 22:52

donny-dont self-assigned this Apr 20, 2023

donny-dont added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Apr 20, 2023

donny-dont requested a review from kkinnunen-apple April 20, 2023 22:57

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 20, 2023

donny-dont removed the merging-blocked Applied to prevent a change from being merged label Apr 20, 2023

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from 95eab95 to 07f99b2 Compare April 20, 2023 23:11

cdumez reviewed Apr 20, 2023

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 20, 2023

donny-dont removed the merging-blocked Applied to prevent a change from being merged label Apr 20, 2023

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from 07f99b2 to e098478 Compare April 20, 2023 23:42

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 20, 2023

kkinnunen-apple reviewed Apr 21, 2023

View reviewed changes

donny-dont removed the merging-blocked Applied to prevent a change from being merged label Apr 25, 2023

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from e098478 to d953dee Compare April 25, 2023 21:23

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 25, 2023

donny-dont removed the merging-blocked Applied to prevent a change from being merged label Apr 25, 2023

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from d953dee to ab14f05 Compare April 25, 2023 22:03

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 25, 2023

donny-dont removed the merging-blocked Applied to prevent a change from being merged label Apr 25, 2023

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from ab14f05 to aada203 Compare April 25, 2023 22:26

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 25, 2023

donny-dont removed the merging-blocked Applied to prevent a change from being merged label May 4, 2023

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from aada203 to c52ac16 Compare May 4, 2023 20:34

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 4, 2023

donny-dont removed the merging-blocked Applied to prevent a change from being merged label May 4, 2023

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from c52ac16 to b987200 Compare May 4, 2023 21:43

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 4, 2023

donny-dont removed the merging-blocked Applied to prevent a change from being merged label May 4, 2023

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from b987200 to 9f11c7c Compare May 4, 2023 22:03

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 4, 2023

donny-dont removed the merging-blocked Applied to prevent a change from being merged label May 5, 2023

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from 9f11c7c to 0af1cec Compare May 5, 2023 00:26

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from 0af1cec to 85b409b Compare May 5, 2023 20:17

donny-dont force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from 85b409b to 1b27815 Compare May 8, 2023 04:54

kkinnunen-apple approved these changes May 8, 2023

View reviewed changes

donny-dont added the merge-queue Applied to send a pull request to merge-queue label May 8, 2023

webkit-commit-queue force-pushed the eng/Use-move-semantics-for-SharedMemoryHandle branch from 1b27815 to a6579e4 Compare May 8, 2023 18:34

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 8, 2023

webkit-commit-queue merged commit a6579e4 into WebKit:main May 8, 2023

Use move semantics for SharedMemory::Handle #12995

Use move semantics for SharedMemory::Handle #12995

Uh oh!

Conversation

donny-dont commented Apr 20, 2023 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

a6579e4

Uh oh!

webkit-early-warning-system commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdumez Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

donny-dont Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

cdumez Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kkinnunen-apple left a comment

Choose a reason for hiding this comment

Uh oh!

kkinnunen-apple Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

kkinnunen-apple Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

kkinnunen-apple Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

kkinnunen-apple Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented May 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

donny-dont commented Apr 20, 2023 •

edited by webkit-early-warning-system

Loading

`a6579e4`

webkit-early-warning-system commented Apr 20, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 20, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 20, 2023 •

edited

Loading

kkinnunen-apple Apr 21, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 25, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 25, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 25, 2023 •

edited

Loading

webkit-early-warning-system commented May 4, 2023 •

edited

Loading

webkit-early-warning-system commented May 4, 2023 •

edited

Loading

webkit-early-warning-system commented May 4, 2023 •

edited

Loading

webkit-early-warning-system commented May 5, 2023 •

edited

Loading

webkit-early-warning-system commented May 5, 2023 •

edited

Loading

webkit-early-warning-system commented May 8, 2023 •

edited

Loading

webkit-early-warning-system commented May 8, 2023 •

edited

Loading