[ iOS ] 2x imported/w3c/web-platform-tests/screen-orientation are near-constant text failures. #13185

marcoscaceres · 2023-04-26T00:38:49Z

`5eb2125`

[ iOS ] 2x imported/w3c/web-platform-tests/screen-orientation are near-constant text failures.
https://bugs.webkit.org/show_bug.cgi?id=255931
rdar://108508861

Reviewed by Chris Dumez.

The cleanup function was accidentally calling "document.screen".
Fixing that revealed a bunch of smaller bugs in the tests.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/page-visibility/resources/window_state_context.js:
(window_state_context.async restore):
(window_state_context):
* LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:
(async if):
(window.test_driver_internal.set_window_rect):
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock.html:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document.html:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents.html:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe.html:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/resources/orientation-utils.js:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/unlock-expected.txt:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/263509@main

72b5d69

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-26T00:39:12Z

EWS run on previous version of this PR (hash c351821)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-26T16:40:22Z

EWS run on previous version of this PR (hash 2be40ea)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-26T18:33:02Z

EWS run on previous version of this PR (hash e59e3b5)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-26T23:21:00Z

Starting EWS tests for 72b5d69. Live statuses available at the PR page, #13185

webkit-early-warning-system · 2023-04-26T23:21:01Z

EWS run on current version of this PR (hash 72b5d69)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

…r-constant text failures. https://bugs.webkit.org/show_bug.cgi?id=255931 rdar://108508861 Reviewed by Chris Dumez. The cleanup function was accidentally calling "document.screen". Fixing that revealed a bunch of smaller bugs in the tests. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/page-visibility/resources/window_state_context.js: (window_state_context.async restore): (window_state_context): * LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js: (async if): (window.test_driver_internal.set_window_rect): * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock.html: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/hidden_document.html: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/nested-documents.html: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe.html: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/resources/orientation-utils.js: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/unlock-expected.txt: * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/263509@main

webkit-commit-queue · 2023-04-28T19:09:39Z

Committed 263509@main (5eb2125): https://commits.webkit.org/263509@main

Reviewed commits have been landed. Closing PR #13185 and removing active labels.

marcoscaceres self-assigned this Apr 26, 2023

marcoscaceres added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Apr 26, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 26, 2023

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Apr 26, 2023

marcoscaceres force-pushed the eng/-iOS--2x-importedw3cweb-platform-testsscreen-orientation-are-near-constant-text-failures- branch from c351821 to 2be40ea Compare April 26, 2023 16:40

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 26, 2023

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Apr 26, 2023

marcoscaceres force-pushed the eng/-iOS--2x-importedw3cweb-platform-testsscreen-orientation-are-near-constant-text-failures- branch from 2be40ea to e59e3b5 Compare April 26, 2023 18:32

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 26, 2023

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Apr 26, 2023

marcoscaceres force-pushed the eng/-iOS--2x-importedw3cweb-platform-testsscreen-orientation-are-near-constant-text-failures- branch from e59e3b5 to 72b5d69 Compare April 26, 2023 23:15

marcoscaceres requested a review from cdumez April 27, 2023 17:14

marcoscaceres marked this pull request as ready for review April 27, 2023 17:14

cdumez approved these changes Apr 27, 2023

View reviewed changes

marcoscaceres added the merge-queue Applied to send a pull request to merge-queue label Apr 28, 2023

webkit-commit-queue force-pushed the eng/-iOS--2x-importedw3cweb-platform-testsscreen-orientation-are-near-constant-text-failures- branch from 72b5d69 to 5eb2125 Compare April 28, 2023 19:09

webkit-commit-queue merged commit 5eb2125 into WebKit:main Apr 28, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 28, 2023

marcoscaceres mentioned this pull request May 2, 2023

Screen Orientation: bug fixes web-platform-tests/wpt#39801

Closed

marcoscaceres deleted the eng/-iOS--2x-importedw3cweb-platform-testsscreen-orientation-are-near-constant-text-failures- branch June 5, 2023 02:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ iOS ] 2x imported/w3c/web-platform-tests/screen-orientation are near-constant text failures. #13185

[ iOS ] 2x imported/w3c/web-platform-tests/screen-orientation are near-constant text failures. #13185

Uh oh!

marcoscaceres commented Apr 26, 2023 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Apr 26, 2023 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Apr 26, 2023 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Apr 26, 2023 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Apr 26, 2023

Uh oh!

webkit-early-warning-system commented Apr 26, 2023 •

edited

Loading

Uh oh!

webkit-commit-queue commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[ iOS ] 2x imported/w3c/web-platform-tests/screen-orientation are near-constant text failures. #13185

[ iOS ] 2x imported/w3c/web-platform-tests/screen-orientation are near-constant text failures. #13185

Uh oh!

Conversation

marcoscaceres commented Apr 26, 2023 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

5eb2125

Uh oh!

webkit-early-warning-system commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Apr 26, 2023

Uh oh!

webkit-early-warning-system commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marcoscaceres commented Apr 26, 2023 •

edited by webkit-early-warning-system

Loading

`5eb2125`

webkit-early-warning-system commented Apr 26, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 26, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 26, 2023 •

edited

Loading

webkit-early-warning-system commented Apr 26, 2023 •

edited

Loading