Skip to content

Add value argument to URLSearchParams's has() and delete()#13500

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
annevk:eng/Add-value-argument-to-URLSearchParamss-has-and-delete
May 5, 2023
Merged

Add value argument to URLSearchParams's has() and delete()#13500
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
annevk:eng/Add-value-argument-to-URLSearchParamss-has-and-delete

Conversation

@annevk
Copy link
Copy Markdown
Contributor

@annevk annevk commented May 5, 2023 •
edited by webkit-early-warning-system
Loading

93a5678

Add value argument to URLSearchParams's has() and delete()
https://bugs.webkit.org/show_bug.cgi?id=256369
rdar://108949109

Reviewed by Chris Dumez.

Aligns WebKit with a recent URLSearchParams change.

Also syncs WPT url/ and new tests are upstreamed via web-platform-tests/wpt#39865

* LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.js:
(test):
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.js:
(test):
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.worker-expected.txt:
* Source/WebCore/html/URLSearchParams.cpp:
(WebCore::URLSearchParams::has const):
(WebCore::URLSearchParams::remove):
* Source/WebCore/html/URLSearchParams.h:
(WebCore::URLSearchParams::remove):
(WebCore::URLSearchParams::has const):
* Source/WebCore/html/URLSearchParams.idl:

Canonical link: https://commits.webkit.org/263726@main

4eef375

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk requested review from cdumez and rniwa as code owners May 5, 2023 15:11
@annevk annevk self-assigned this May 5, 2023
@annevk annevk added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label May 5, 2023
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 5, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 901aba4)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress
✅ 🛠 watch
⏳ 🛠 watch-sim

cdumez
cdumez reviewed May 5, 2023
View reviewed changes
@annevk annevk force-pushed the eng/Add-value-argument-to-URLSearchParamss-has-and-delete branch from 901aba4 to 8ad7f66 Compare May 5, 2023 15:35
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 5, 2023 •
edited
Loading

EWS run on current version of this PR (hash 8ad7f66)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style loading 🛠 ios loading 🛠 mac loading 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings loading 🛠 ios-sim loading 🛠 mac-AS-debug loading 🧪 wpe-wk2
loading 🧪 webkitperl loading 🧪 ios-wk2 loading 🧪 api-mac loading 🛠 gtk
⏳ 🧪 webkitpy loading 🧪 ios-wk2-wpt loading 🧪 mac-wk1 loading 🧪 gtk-wk2
loading 🧪 api-ios loading 🧪 mac-wk2 loading 🧪 api-gtk
loading 🛠 tv loading 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim loading 🧪 mac-wk2-stress
loading 🛠 watch
⏳ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 5, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 8ad7f66)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk requested a review from cdumez May 5, 2023 15:39
cdumez
cdumez approved these changes May 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annevk annevk force-pushed the eng/Add-value-argument-to-URLSearchParamss-has-and-delete branch from 8ad7f66 to 4eef375 Compare May 5, 2023 17:05
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 5, 2023

Starting EWS tests for 4eef375. Live statuses available at the PR page, #13500

@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 5, 2023 •
edited
Loading

EWS run on current version of this PR (hash 4eef375)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk added the merge-queue Applied to send a pull request to merge-queue label May 5, 2023
@annevk
Add value argument to URLSearchParams's has() and delete()
93a5678 
https://bugs.webkit.org/show_bug.cgi?id=256369
rdar://108949109

Reviewed by Chris Dumez.

Aligns WebKit with a recent URLSearchParams change.

Also syncs WPT url/ and new tests are upstreamed via web-platform-tests/wpt#39865.

* LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.js:
(test):
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.js:
(test):
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.worker-expected.txt:
* Source/WebCore/html/URLSearchParams.cpp:
(WebCore::URLSearchParams::has const):
(WebCore::URLSearchParams::remove):
* Source/WebCore/html/URLSearchParams.h:
(WebCore::URLSearchParams::remove):
(WebCore::URLSearchParams::has const):
* Source/WebCore/html/URLSearchParams.idl:

Canonical link: https://commits.webkit.org/263726@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-value-argument-to-URLSearchParamss-has-and-delete branch from 4eef375 to 93a5678 Compare May 5, 2023 18:24
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented May 5, 2023

Committed 263726@main (93a5678): https://commits.webkit.org/263726@main

Reviewed commits have been landed. Closing PR #13500 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 93a5678 into WebKit:main May 5, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 5, 2023
@annevk annevk deleted the eng/Add-value-argument-to-URLSearchParamss-has-and-delete branch May 5, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez cdumez approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

Assignees

@annevk annevk

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@annevk @webkit-early-warning-system @webkit-commit-queue @cdumez