Skip to content

Conversation

@graouts
Copy link
Contributor

@graouts graouts commented May 10, 2023

be05571

Don't get transitions of zoom
https://bugs.webkit.org/show_bug.cgi?id=145136

Reviewed by Antti Koivisto.

Let's remove animation support for "zoom" altogether. This matches Chrome's behavior and Firefox does
not implement this non-standard property at all.

* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-value-003-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/support/properties.js:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Canonical link: https://commits.webkit.org/263908@main

0d99461

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@graouts graouts self-assigned this May 10, 2023
@graouts graouts added the Animations Bugs related to CSS + SVG animations and transitions label May 10, 2023
@graouts graouts requested a review from smfr May 10, 2023 09:00
@Ahmad-S792
Copy link
Contributor

@graouts - by any chance, will it make this bug invalid? I tried in the past to fix this with this PR but due to lack of proper test, I was not able to fix it.

@graouts
Copy link
Contributor Author

graouts commented May 10, 2023

@graouts - by any chance, will it make this bug invalid? I tried in the past to fix this with this PR but due to lack of proper test, I was not able to fix it.

I don't think this will have any impact on that bug. This is merely about animating the zoom property itself.

@Ahmad-S792
Copy link
Contributor

@graouts - by any chance, will it make this bug invalid? I tried in the past to fix this with this PR but due to lack of proper test, I was not able to fix it.

I don't think this will have any impact on that bug. This is merely about animating the zoom property itself.

Cool! No worries. Might have mixed things up on my side.

@graouts graouts added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2023
https://bugs.webkit.org/show_bug.cgi?id=145136

Reviewed by Antti Koivisto.

Let's remove animation support for "zoom" altogether. This matches Chrome's behavior and Firefox does
not implement this non-standard property at all.

* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-value-003-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/support/properties.js:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Canonical link: https://commits.webkit.org/263908@main
@webkit-commit-queue webkit-commit-queue force-pushed the remove-zoom-animation-support branch from 0d99461 to be05571 Compare May 10, 2023 16:27
@webkit-commit-queue
Copy link
Collaborator

Committed 263908@main (be05571): https://commits.webkit.org/263908@main

Reviewed commits have been landed. Closing PR #13686 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit be05571 into WebKit:main May 10, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2023
@graouts graouts deleted the remove-zoom-animation-support branch May 10, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Animations Bugs related to CSS + SVG animations and transitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants