Skip to content

[WGSL] Convert remaining AST nodes to be arena allocated#13706

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
tadeuzagallo:eng/WGSL-Convert-remaining-AST-nodes-to-be-arena-allocated
May 11, 2023
Merged

[WGSL] Convert remaining AST nodes to be arena allocated#13706
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
tadeuzagallo:eng/WGSL-Convert-remaining-AST-nodes-to-be-arena-allocated

Conversation

@tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented May 10, 2023 •
edited by webkit-early-warning-system
Loading

b136ade

[WGSL] Convert remaining AST nodes to be arena allocated
https://bugs.webkit.org/show_bug.cgi?id=256603
rdar://109163635

Reviewed by Dan Glastonbury.

Convert the final remaining nodes and remove the (now unused) parser helper macros

* Source/WebGPU/WGSL/AST/ASTBuilder.cpp:
* Source/WebGPU/WGSL/AST/ASTBuilder.h:
* Source/WebGPU/WGSL/AST/ASTDirective.h:
(WGSL::AST::Directive::name const):
* Source/WebGPU/WGSL/AST/ASTIdentifier.h:
(WGSL::AST::Identifier::Identifier):
* Source/WebGPU/WGSL/AST/ASTNode.h:
(WGSL::AST::Node::kind const):
(WGSL::AST::Node::Node):
* Source/WebGPU/WGSL/AST/ASTPointerDereference.h:
* Source/WebGPU/WGSL/Parser.cpp:

Canonical link: https://commits.webkit.org/263958@main

34faaf6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo self-assigned this May 10, 2023
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label May 10, 2023
@tadeuzagallo tadeuzagallo changed the title [WGSL] Convert [WGSL] Convert remaining AST nodes to be arena allocated May 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 10, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 80e9e5e)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings   🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
⏳ 🧪 webkitpy   🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ⏳ 🧪 gtk-wk2
  🧪 api-ios ❌ 🧪 mac-wk2   🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
❌ 🛠 watch
⏳ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 10, 2023
@tadeuzagallo tadeuzagallo force-pushed the eng/WGSL-Convert-remaining-AST-nodes-to-be-arena-allocated branch from 80e9e5e to ee400d9 Compare May 10, 2023 18:51
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 10, 2023 •
edited
Loading

EWS run on previous version of this PR (hash ee400d9)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios   🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc ❌ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
  🛠 tv-sim   🧪 mac-wk2-stress
❌ 🛠 watch
⏳ 🛠 watch-sim

@tadeuzagallo tadeuzagallo force-pushed the eng/WGSL-Convert-remaining-AST-nodes-to-be-arena-allocated branch from ee400d9 to 0709d6a Compare May 10, 2023 18:57
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 10, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 0709d6a)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

djg
djg approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tadeuzagallo tadeuzagallo removed the merging-blocked Applied to prevent a change from being merged label May 11, 2023
@tadeuzagallo tadeuzagallo force-pushed the eng/WGSL-Convert-remaining-AST-nodes-to-be-arena-allocated branch from 0709d6a to 34faaf6 Compare May 11, 2023 09:33
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 11, 2023 •
edited
Loading

EWS run on current version of this PR (hash 34faaf6)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label May 11, 2023
@tadeuzagallo
[WGSL] Convert remaining AST nodes to be arena allocated
b136ade 
https://bugs.webkit.org/show_bug.cgi?id=256603
rdar://109163635

Reviewed by Dan Glastonbury.

Convert the final remaining nodes and remove the (now unused) parser helper macros

* Source/WebGPU/WGSL/AST/ASTBuilder.cpp:
* Source/WebGPU/WGSL/AST/ASTBuilder.h:
* Source/WebGPU/WGSL/AST/ASTDirective.h:
(WGSL::AST::Directive::name const):
* Source/WebGPU/WGSL/AST/ASTIdentifier.h:
(WGSL::AST::Identifier::Identifier):
* Source/WebGPU/WGSL/AST/ASTNode.h:
(WGSL::AST::Node::kind const):
(WGSL::AST::Node::Node):
* Source/WebGPU/WGSL/AST/ASTPointerDereference.h:
* Source/WebGPU/WGSL/Parser.cpp:

Canonical link: https://commits.webkit.org/263958@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Convert-remaining-AST-nodes-to-be-arena-allocated branch from 34faaf6 to b136ade Compare May 11, 2023 10:34
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented May 11, 2023

Committed 263958@main (b136ade): https://commits.webkit.org/263958@main

Reviewed commits have been landed. Closing PR #13706 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b136ade into WebKit:main May 11, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 11, 2023
@tadeuzagallo tadeuzagallo deleted the eng/WGSL-Convert-remaining-AST-nodes-to-be-arena-allocated branch May 17, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djg djg djg approved these changes

@litherum litherum Awaiting requested review from litherum

@mwyrzykowski mwyrzykowski Awaiting requested review from mwyrzykowski mwyrzykowski is a code owner

Assignees

@tadeuzagallo tadeuzagallo

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tadeuzagallo @webkit-early-warning-system @webkit-commit-queue @djg @webkit-ews-buildbot