Use the same simulated iPhone model for layout tests an API tests #13897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
Collaborator
|
EWS run on previous version of this PR (hash 2193d1a) Details
|
gsnedders
reviewed
May 15, 2023
Member
There was a problem hiding this comment.
Are there any cases where this differs to .endswith('-simulator')?
Member
Author
There was a problem hiding this comment.
Not at the moment, but I think in more accurately reflects the sentiment here. If someone were to do something like ios-simulator-legacy (which would seem a perfectly reasonable port name), ends with('-simulator') here would break that class name.
JonWBedard
force-pushed
the
eng/Use-the-same-simulated-iPhone-model-for-layout-tests-an-API-tests
branch
from
2193d1a to
783883a
Compare
JonWBedard
added
the
unsafe-merge-queue
Collaborator
|
EWS run on current version of this PR (hash 783883a) Details
|
https://bugs.webkit.org/show_bug.cgi?id=239885 rdar://92505373 Rubber-stamped by Aakash Jain. run-api-tests should use the same default device model that layout tests. * Tools/Scripts/webkitpy/api_tests/manager.py: (Manager._initialize_devices): Use the default device model as specified in the port class. Add a temporary override for iOS until https://bugs.webkit.org/show_bug.cgi?id=256806 is resolved. Canonical link: https://commits.webkit.org/264115@main
webkit-commit-queue
force-pushed
the
eng/Use-the-same-simulated-iPhone-model-for-layout-tests-an-API-tests
branch
from
783883a to
4518454
Compare
Collaborator
|
Committed 264115@main (4518454): https://commits.webkit.org/264115@main Reviewed commits have been landed. Closing PR #13897 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
JonWBedard
deleted the
eng/Use-the-same-simulated-iPhone-model-for-layout-tests-an-API-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4518454
783883a
🧪 bindings🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 webkitpy🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 api-gtk🧪 mac-AS-debug-wk2🛠 tv-sim🛠 watch