[Cocoa] Call [AVCaptureDevice ensureServerConnection] when new extensions are made to the GPU Process #14276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-carlson
approved these changes
May 24, 2023
Collaborator
|
EWS run on current version of this PR (hash f552b6c) Details
|
…ions are made to the GPU Process https://bugs.webkit.org/show_bug.cgi?id=257241 <rdar://109380900> Reviewed by Eric Carlson. Our current code only calls [AVCaptureDevice ensureServerConnection] the first time we extend the sandbox. This can lead to problems if the user visits a site that only needs Microphone access (for example), and then visits a site that needs Camera access. Because the camera-related extensions are only recognized by the video capture system when [AVCaptureDevice ensureServiceConnection] is called, the fact that we called it before the new sandbox extensions were in place mean we never activate the relevant features. To fix this, we should simply call [AVCaptureDevice ensureServerConnection] any time we extend the sandbox. I have confirmed with the relevant teams that this call is low-cost (performance wise), and is not harmful to call repeatedly for things that have already been activated. This patch also adds new logging to help debug similar problems in the future. * Source/WebKit/GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::updateSandboxAccess): Add logging. (WebKit::GPUProcess::updateCaptureAccess): Ditto. * Source/WebKit/GPUProcess/cocoa/GPUProcessCocoa.mm: (WebKit::GPUProcess::ensureAVCaptureServerConnection): Add new logging, no longer make this a 'std::call_once'. Canonical link: https://commits.webkit.org/264460@main
webkit-commit-queue
force-pushed
the
eng/Cocoa-Call-AVCaptureDevice-ensureServerConnection-when-new-extensions-are-made-to-the-GPU-Process
branch
from
f552b6c to
fe4af8b
Compare
Collaborator
|
Committed 264460@main (fe4af8b): https://commits.webkit.org/264460@main Reviewed commits have been landed. Closing PR #14276 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fe4af8b
f552b6c
🧪 api-ios🧪 mac-AS-debug-wk2