REGRESSION(2.41): [GTK] Contents not rendered in new web view when realized after configure and frame #14346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
EWS run on current version of this PR (hash 8f6c227) Details
|
mcatanzaro
approved these changes
May 25, 2023
Contributor
mcatanzaro
left a comment
mcatanzaro
left a comment
There was a problem hiding this comment.
Well I don't see anything obviously bad with the changes (not that I'd be likely to notice). And I've tested it and verified the bug is actually fixed. Thanks.
webkit-ews-buildbot
added
the
merging-blocked
carlosgcampos
added
unsafe-merge-queue
…alized after configure and frame https://bugs.webkit.org/show_bug.cgi?id=257324 Reviewed by Michael Catanzaro. In case of realize happening after the configure and frame, we create a committed source, but it's not ready for rendering. This patch splits the swap method into swap and prepareForRendering. When a new frame is available we always do swap, to be in sync with the web process, but only prepareForRendering when view is realized. When realize happens after the configure and frame we only need to call prepareForRendering(). * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp: (WebKit::AcceleratedBackingStoreDMABuf::Texture::~Texture): (WebKit::AcceleratedBackingStoreDMABuf::Texture::swap): (WebKit::AcceleratedBackingStoreDMABuf::Surface::map const): (WebKit::AcceleratedBackingStoreDMABuf::Surface::swap): (WebKit::AcceleratedBackingStoreDMABuf::Surface::prepareForRendering): (WebKit::AcceleratedBackingStoreDMABuf::frame): (WebKit::AcceleratedBackingStoreDMABuf::realize): * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h: Canonical link: https://commits.webkit.org/264558@main
webkit-commit-queue
force-pushed
the
gtk4-late-realize
branch
from
8f6c227 to
c60b4c7
Compare
Collaborator
|
Committed 264558@main (c60b4c7): https://commits.webkit.org/264558@main Reviewed commits have been landed. Closing PR #14346 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c60b4c7
8f6c227