Skip to content

imported/w3c/web-platform-tests/screen-orientation/lock-basic.html is incorrectly marked as flaky#14614

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
marcoscaceres:eng/importedw3cweb-platform-testsscreen-orientationlock-basic-html-is-incorrectly-marked-as-flaky
Jun 6, 2023
Merged

imported/w3c/web-platform-tests/screen-orientation/lock-basic.html is incorrectly marked as flaky#14614
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
marcoscaceres:eng/importedw3cweb-platform-testsscreen-orientationlock-basic-html-is-incorrectly-marked-as-flaky

Conversation

@marcoscaceres
Copy link
Copy Markdown
Contributor

@marcoscaceres marcoscaceres commented Jun 2, 2023

54153c5

imported/w3c/web-platform-tests/screen-orientation/lock-basic.html is incorrectly marked as flaky
https://bugs.webkit.org/show_bug.cgi?id=257634
rdar://110150849

Reviewed by Cameron McCormack.

The test is not flaky anymore on ios-wk2, so removed it from ios-wk2/TestExpectations.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/264892@main

1a8cb20

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres self-assigned this Jun 2, 2023
@marcoscaceres marcoscaceres added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 2, 2023
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Jun 2, 2023

@marcoscaceres marcoscaceres requested a review from HerculesH June 2, 2023 04:39
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 2, 2023
@marcoscaceres marcoscaceres added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels Jun 6, 2023
… incorrectly marked as flaky

https://bugs.webkit.org/show_bug.cgi?id=257634
rdar://110150849

Reviewed by Cameron McCormack.

The test is not flaky anymore on ios-wk2, so removed it from ios-wk2/TestExpectations.

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/264892@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/importedw3cweb-platform-testsscreen-orientationlock-basic-html-is-incorrectly-marked-as-flaky branch from 1a8cb20 to 54153c5 Compare June 6, 2023 05:15
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 264892@main (54153c5): https://commits.webkit.org/264892@main

Reviewed commits have been landed. Closing PR #14614 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 54153c5 into WebKit:main Jun 6, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 6, 2023
@marcoscaceres marcoscaceres deleted the eng/importedw3cweb-platform-testsscreen-orientationlock-basic-html-is-incorrectly-marked-as-flaky branch January 17, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants