Skip to content

Lazily allocate the SharedVideoFrameWriter in RemoteDisplayListRecorderProxy #15170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Jun 22, 2023
Merged

Lazily allocate the SharedVideoFrameWriter in RemoteDisplayListRecorderProxy #15170

webkit-commit-queue merged 1 commit into from
Jun 22, 2023

Conversation

@smfr
Copy link
Contributor

@smfr smfr commented Jun 22, 2023 •
edited by webkit-early-warning-system
Loading

e97b079

Lazily allocate the SharedVideoFrameWriter in RemoteDisplayListRecorderProxy
https://bugs.webkit.org/show_bug.cgi?id=258379
rdar://111133625

Reviewed by Youenn Fablet.

Every RemoteImageBufferProxy has a RemoteDisplayListRecorderProxy, and every RemoteDisplayListRecorderProxy has
a SharedVideoFrameWriter, which owns an IPC::Semaphore. The creation and destruction time for this semaphore
was significant when creating/destroying ImageBuffers.

Since SharedVideoFrameWriter is only rarely used, in the case where video frames are drawing into a buffer,
we can lazily allocate it.

* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::recordPaintVideoFrame):
(WebKit::RemoteDisplayListRecorderProxy::disconnect):
(WebKit::RemoteDisplayListRecorderProxy::ensureSharedVideoFrameWriter):
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:

Canonical link: https://commits.webkit.org/265427@main

03c81f8

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@smfr smfr requested a review from cdumez as a code owner June 22, 2023 00:54
@smfr smfr self-assigned this Jun 22, 2023
@smfr smfr added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Jun 22, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 2bbae9b)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 22, 2023
@smfr smfr removed the merging-blocked Applied to prevent a change from being merged label Jun 22, 2023
@smfr smfr force-pushed the eng/Lazily-allocate-the-SharedVideoFrameWriter-in-RemoteDisplayListRecorderProxy branch from 2bbae9b to 03c81f8 Compare June 22, 2023 19:26
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 22, 2023 •
edited
Loading

EWS run on current version of this PR (hash 03c81f8)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@smfr smfr added the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2023
@smfr
Lazily allocate the SharedVideoFrameWriter in RemoteDisplayListRecord…
e97b079 
…erProxy

https://bugs.webkit.org/show_bug.cgi?id=258379
rdar://111133625

Reviewed by Youenn Fablet.

Every RemoteImageBufferProxy has a RemoteDisplayListRecorderProxy, and every RemoteDisplayListRecorderProxy has
a SharedVideoFrameWriter, which owns an IPC::Semaphore. The creation and destruction time for this semaphore
was significant when creating/destroying ImageBuffers.

Since SharedVideoFrameWriter is only rarely used, in the case where video frames are drawing into a buffer,
we can lazily allocate it.

* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::recordPaintVideoFrame):
(WebKit::RemoteDisplayListRecorderProxy::disconnect):
(WebKit::RemoteDisplayListRecorderProxy::ensureSharedVideoFrameWriter):
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:

Canonical link: https://commits.webkit.org/265427@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Lazily-allocate-the-SharedVideoFrameWriter-in-RemoteDisplayListRecorderProxy branch from 03c81f8 to e97b079 Compare June 22, 2023 22:03
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jun 22, 2023

Committed 265427@main (e97b079): https://commits.webkit.org/265427@main

Reviewed commits have been landed. Closing PR #15170 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e97b079 into WebKit:main Jun 22, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youennf youennf youennf approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@smfr smfr

Labels

WebKit Process Model Bugs related to WebKit's multi-process architecture

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smfr @webkit-early-warning-system @webkit-commit-queue @youennf @webkit-ews-buildbot