Remove ShadowRoot::resetStyleInheritance mechanism#16781
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Aug 17, 2023
Merged
Remove ShadowRoot::resetStyleInheritance mechanism#16781webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on current version of this PR (hash 62c995f) Details
|
alanbaradlay
approved these changes
Aug 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=260338 rdar://114015755 Reviewed by Alan Baradlay. UA shadow trees should just use 'all: initial' if needed. * Source/WebCore/dom/ShadowRoot.cpp: (WebCore::ShadowRoot::setResetStyleInheritance): Deleted. * Source/WebCore/dom/ShadowRoot.h: * Source/WebCore/html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot): * Source/WebCore/html/shadow/ShadowPseudoIds.cpp: (WebCore::ShadowPseudoIds::webkitPluginReplacement): Deleted. Also remove this non-referenced pseudo element name. * Source/WebCore/html/shadow/ShadowPseudoIds.h: * Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp: This is the only client for the mechanism, use 'all:initial' instead. (WebCore::YouTubeEmbedShadowElement::create): * Source/WebCore/style/StyleResolver.cpp: (WebCore::Style::Resolver::State::State): Canonical link: https://commits.webkit.org/266999@main
62c995f to
121c1a4
Compare
Collaborator
|
Committed 266999@main (121c1a4): https://commits.webkit.org/266999@main Reviewed commits have been landed. Closing PR #16781 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
121c1a4
62c995f