Skip to content

Remove ShadowRoot::resetStyleInheritance mechanism#16781

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
anttijk:remove-reset-style-inheritance
Aug 17, 2023
Merged

Remove ShadowRoot::resetStyleInheritance mechanism#16781
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
anttijk:remove-reset-style-inheritance

Conversation

@anttijk
Copy link
Contributor

@anttijk anttijk commented Aug 17, 2023

121c1a4

Remove ShadowRoot::resetStyleInheritance mechanism
https://bugs.webkit.org/show_bug.cgi?id=260338
rdar://114015755

Reviewed by Alan Baradlay.

UA shadow trees should just use 'all: initial' if needed.

* Source/WebCore/dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::setResetStyleInheritance): Deleted.
* Source/WebCore/dom/ShadowRoot.h:
* Source/WebCore/html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot):
* Source/WebCore/html/shadow/ShadowPseudoIds.cpp:
(WebCore::ShadowPseudoIds::webkitPluginReplacement): Deleted.

Also remove this non-referenced pseudo element name.

* Source/WebCore/html/shadow/ShadowPseudoIds.h:
* Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp:

This is the only client for the mechanism, use 'all:initial' instead.

(WebCore::YouTubeEmbedShadowElement::create):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::State::State):

Canonical link: https://commits.webkit.org/266999@main

62c995f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk requested review from cdumez and rniwa as code owners August 17, 2023 09:08
@anttijk anttijk self-assigned this Aug 17, 2023
@anttijk anttijk added the CSS Cascading Style Sheets implementation label Aug 17, 2023
@anttijk anttijk added the merge-queue Applied to send a pull request to merge-queue label Aug 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=260338
rdar://114015755

Reviewed by Alan Baradlay.

UA shadow trees should just use 'all: initial' if needed.

* Source/WebCore/dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::setResetStyleInheritance): Deleted.
* Source/WebCore/dom/ShadowRoot.h:
* Source/WebCore/html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot):
* Source/WebCore/html/shadow/ShadowPseudoIds.cpp:
(WebCore::ShadowPseudoIds::webkitPluginReplacement): Deleted.

Also remove this non-referenced pseudo element name.

* Source/WebCore/html/shadow/ShadowPseudoIds.h:
* Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp:

This is the only client for the mechanism, use 'all:initial' instead.

(WebCore::YouTubeEmbedShadowElement::create):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::State::State):

Canonical link: https://commits.webkit.org/266999@main
@webkit-commit-queue webkit-commit-queue force-pushed the remove-reset-style-inheritance branch from 62c995f to 121c1a4 Compare August 17, 2023 15:09
@webkit-commit-queue
Copy link
Collaborator

Committed 266999@main (121c1a4): https://commits.webkit.org/266999@main

Reviewed commits have been landed. Closing PR #16781 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 17, 2023
@webkit-commit-queue webkit-commit-queue merged commit 121c1a4 into WebKit:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants