Skip to content

[ews-build.webkit.org] Remove check-github-integrity (Part 1)#1687

Merged
webkit-commit-queue merged 0 commit intoWebKit:mainfrom
JonWBedard:eng/ews-build-webkit-org-Remove-check-github-integrity
Jun 22, 2022
Merged

[ews-build.webkit.org] Remove check-github-integrity (Part 1)#1687
webkit-commit-queue merged 0 commit intoWebKit:mainfrom
JonWBedard:eng/ews-build-webkit-org-Remove-check-github-integrity

Conversation

@JonWBedard
Copy link
Copy Markdown
Member

@JonWBedard JonWBedard commented Jun 22, 2022 •
edited by webkit-commit-queue
Loading

e4d783c

[ews-build.webkit.org] Remove check-github-integrity (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=241859
<rdar://93108238>

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-build/factories.py:
(CommitQueueFactory.__init__): Remove VerifyGitHubIntegrity.
(MergeQueueFactoryBase.__init__): Ditto.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/steps.py:
(VerifyGitHubIntegrity): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/251743@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Jun 22, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Jun 22, 2022
@JonWBedard
Copy link
Copy Markdown
Member Author

JonWBedard commented Jun 22, 2022

Landing this now, although we don't want to deploy this change until tomorrow morning (6/23) when we disable Subversion.

@JonWBedard JonWBedard added the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-build-webkit-org-Remove-check-github-integrity branch from 3778d3e to e4d783c Compare June 22, 2022 18:03
@webkit-commit-queue webkit-commit-queue merged commit e4d783c into WebKit:main Jun 22, 2022
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Jun 22, 2022

Committed r295738 (251743@main): https://commits.webkit.org/251743@main

Reviewed commits have been landed. Closing PR #1687 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2022
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Remove-check-github-integrity branch June 23, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanhaddad ryanhaddad ryanhaddad approved these changes

@aj062 aj062 Awaiting requested review from aj062

Assignees

@JonWBedard JonWBedard

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JonWBedard @webkit-commit-queue @ryanhaddad @webkit-early-warning-system