Skip to content

Deploy more smart pointers in Source/WebKit/Shared/ #16873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2023
Merged

Deploy more smart pointers in Source/WebKit/Shared/ #16873

merged 1 commit into from
Aug 24, 2023

Conversation

@rniwa
Copy link
Member

@rniwa rniwa commented Aug 20, 2023 •
edited by webkit-early-warning-system
Loading

cc21d6f

Deploy more smart pointers in Source/WebKit/Shared/
https://bugs.webkit.org/show_bug.cgi?id=260440

Reviewed by Wenson Hsieh.

Deployed more smart pointers.

* Source/WebKit/Shared/APIWebArchive.mm:
(API::WebArchive::WebArchive):
* Source/WebKit/Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::processChecked const): Added.
(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::~AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::negotiatedLegacyTLS const):
* Source/WebKit/Shared/Authentication/AuthenticationManager.h:
* Source/WebKit/Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray objectAtIndex:]):
* Source/WebKit/Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary objectForKey:]):
* Source/WebKit/Shared/EditingRange.cpp:
(WebKit::EditingRange::toRange):
(WebKit::EditingRange::fromRange):
* Source/WebKit/Shared/IPCTester.cpp:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::encode const):
(WebKit::RemoteLayerBackingStore::drawInContext):
* Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::dump):
* Source/WebKit/Shared/UserData.cpp:
(WebKit::shouldTransform):
(WebKit::transformGraph):
(WebKit::UserData::encode):
* Source/WebKit/Shared/WebConnection.cpp:
(WebKit::WebConnection::handleMessage):
* Source/WebKit/Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::separatorItem):
* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):
(WebKit::WebHitTestResultData::elementBoundingBoxInWindowCoordinates):

Canonical link: https://commits.webkit.org/267232@main

ccd55a3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa self-assigned this Aug 20, 2023
@rniwa rniwa added the WebKit2 Bugs relating to the WebKit2 API layer label Aug 20, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 20, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 48c89a7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
❌ 🛠 watch
❌ 🛠 watch-sim

@rniwa rniwa requested review from smfr and whsieh August 20, 2023 07:23
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 20, 2023
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Aug 20, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 20, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 8f38ff5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 27b0fa0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ⏳ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim
✅ 🛠 watch ⏳ 🛠 jsc-mips
✅ 🛠 watch-sim ⏳ 🧪 jsc-mips-tests

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 5364353)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

whsieh
whsieh approved these changes Aug 23, 2023
View reviewed changes
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 23, 2023 •
edited
Loading

EWS run on previous version of this PR (hash c383e04)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 23, 2023
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Aug 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 23, 2023 •
edited
Loading

EWS run on previous version of this PR (hash ba9b065)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ❌ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim   🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 23, 2023
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Aug 23, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 23, 2023 •
edited
Loading

EWS run on previous version of this PR (hash b11940c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🛠 gtk
  🧪 ios-wk2-wpt ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Aug 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 23, 2023 •
edited
Loading

EWS run on current version of this PR (hash ccd55a3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 24, 2023
@rniwa
Deploy more smart pointers in Source/WebKit/Shared/
cc21d6f 
https://bugs.webkit.org/show_bug.cgi?id=260440

Reviewed by Wenson Hsieh.

Deployed more smart pointers.

* Source/WebKit/Shared/APIWebArchive.mm:
(API::WebArchive::WebArchive):
* Source/WebKit/Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::processChecked const): Added.
(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::~AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::negotiatedLegacyTLS const):
* Source/WebKit/Shared/Authentication/AuthenticationManager.h:
* Source/WebKit/Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray objectAtIndex:]):
* Source/WebKit/Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary objectForKey:]):
* Source/WebKit/Shared/EditingRange.cpp:
(WebKit::EditingRange::toRange):
(WebKit::EditingRange::fromRange):
* Source/WebKit/Shared/IPCTester.cpp:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::encode const):
(WebKit::RemoteLayerBackingStore::drawInContext):
* Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::dump):
* Source/WebKit/Shared/UserData.cpp:
(WebKit::shouldTransform):
(WebKit::transformGraph):
(WebKit::UserData::encode):
* Source/WebKit/Shared/WebConnection.cpp:
(WebKit::WebConnection::handleMessage):
* Source/WebKit/Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::separatorItem):
* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):
(WebKit::WebHitTestResultData::elementBoundingBoxInWindowCoordinates):

Canonical link: https://commits.webkit.org/267232@main
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Aug 24, 2023

Committed 267232@main (cc21d6f): https://commits.webkit.org/267232@main

Reviewed commits have been landed. Closing PR #16873 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cc21d6f into WebKit:main Aug 24, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 24, 2023
@rniwa rniwa deleted the fix260440 branch August 24, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whsieh whsieh whsieh approved these changes

@smfr smfr Awaiting requested review from smfr

Assignees

@rniwa rniwa

Labels

WebKit2 Bugs relating to the WebKit2 API layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rniwa @webkit-early-warning-system @webkit-commit-queue @whsieh @webkit-ews-buildbot