[GStreamer] Video not resized with playbin3 on i.MX8M Plus and COG

[marex]

7d6cd5e

[GStreamer] Video not resized with playbin3 on i.MX8M Plus and COG
https://bugs.webkit.org/show_bug.cgi?id=260482

Reviewed by Philippe Normand.

When using WEBKIT_GST_USE_PLAYBIN3=1 and cog to open h264 video (e.g.
Big Buck Bunny h264 1920x1080 mp4), then only single message is delivered
to MediaPlayerPrivateGStreamer::handleStreamCollectionMessage() . The
current workaround check would bail out since the message source is
decodebin3, while the m_source is filesrc . This prevents player->updateTracks
from being called, and thus m_hasVideo from being set, and thus
hasVideo() in MediaPlayerPrivateGStreamer::naturalSize() returns false
and MediaPlayerPrivateGStreamer::naturalSize returns FloatSize()
size, which is 0x0. The resulting video element in the browser has
minimum height set and is not correctly resized.

Limit the MediaPlayerPrivateGStreamer::handleStreamCollectionMessage()
workaround only to non-filesrc, since filesrc is not generating the
stream-collection events.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):

Canonical link: https://commits.webkit.org/267515@main

79efdef

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 1a69da8)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[philn]

Seems like this is breaking 2 tests, Found 2 new test failures: imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-without-codecs-parameter.html, imported/w3c/web-platform-tests/media-source/mediasource-detach.html

I'm on sick leave, assigning calvaris to review

[calvaris]

Well, the patch looks good, but if tests fail, they need to be investigated by @marex before proceeding.

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 5791ff1)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	✅ 🛠 gtk
	🧪 ios-wk2-wpt	🧪 mac-wk1	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	🧪 api-ios	🧪 mac-wk2	🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	⏳ 🛠 tv-sim
	⏳ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 79efdef)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[calvaris]

It looks like tests keep failing.

[marex]

@calvaris Can you provide any hints what to do about that test ? I don't even have any apple hardware to test on.

[philn]

It looks like tests keep failing.

I see no failure? The mac one is false-positive.

[philn]

Can you remove this from the commit message?

Limit the MediaPlayerPrivateGStreamer::handleStreamCollectionMessage()
workaround only to gstreamer releases before 1.20.y, since this bug
seems to be fixed in 1.20.y and newer.

[marex]

Can you remove this from the commit message?

Limit the MediaPlayerPrivateGStreamer::handleStreamCollectionMessage() workaround only to gstreamer releases before 1.20.y, since this bug seems to be fixed in 1.20.y and newer.

The description of the MR should now be synchronized with the patch.

[webkit-commit-queue]

Committed 267515@main (7d6cd5e): https://commits.webkit.org/267515@main

Reviewed commits have been landed. Closing PR #16901 and removing active labels.

[calvaris]

Ah, sorry, I misread the bot name and thought it was one of the linux ones.