REGRESSION (267279@main): [ macOS Debug ] ASSERTION FAILED: WebCore::MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator#17096
Merged
Conversation
rr-codes
approved these changes
Aug 26, 2023
alanbaradlay
approved these changes
Aug 26, 2023
Collaborator
|
EWS run on current version of this PR (hash b8aa86a) Details
|
…MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator https://bugs.webkit.org/show_bug.cgi?id=260742 rdar://114472398 Reviewed by Richard Robinson and Alan Baradlay. Fix incorrect assertion. Covered by tests. * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::completeSeek): Canonical link: https://commits.webkit.org/267314@main
b8aa86a to
f005b55
Compare
Collaborator
|
Committed 267314@main (f005b55): https://commits.webkit.org/267314@main Reviewed commits have been landed. Closing PR #17096 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f005b55
b8aa86a
🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🧪 mac-wk2🧪 api-gtk🧪 mac-AS-debug-wk2🛠 watch