Skip to content

REGRESSION (267279@main): [ macOS Debug ] ASSERTION FAILED: WebCore::MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator#17096

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
jyavenard:eng/REGRESSION-267279main--macOS-Debug--ASSERTION-FAILED-WebCoreMediaSourcecompleteSeekSeeksCallbackAggregatorSeeksCallbackAggregator
Aug 26, 2023
Merged

REGRESSION (267279@main): [ macOS Debug ] ASSERTION FAILED: WebCore::MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator#17096
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
jyavenard:eng/REGRESSION-267279main--macOS-Debug--ASSERTION-FAILED-WebCoreMediaSourcecompleteSeekSeeksCallbackAggregatorSeeksCallbackAggregator

Conversation

@jyavenard
Copy link
Copy Markdown
Member

@jyavenard jyavenard commented Aug 26, 2023

f005b55

REGRESSION (267279@main): [ macOS Debug ] ASSERTION FAILED: WebCore::MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator
https://bugs.webkit.org/show_bug.cgi?id=260742
rdar://114472398

Reviewed by Richard Robinson and Alan Baradlay.

Fix incorrect assertion.

Covered by tests.

* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::completeSeek):

Canonical link: https://commits.webkit.org/267314@main

b8aa86a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 🧪 api-mac ✅ 🛠 gtk
🧪 ios-wk2-wpt 🧪 mac-wk1 🧪 gtk-wk2
✅ 🧪 api-ios 🧪 mac-wk2 🧪 api-gtk
✅ 🛠 tv 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge 🛠 watch
✅ 🛠 watch-sim

@jyavenard jyavenard self-assigned this Aug 26, 2023
@jyavenard jyavenard added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Aug 26, 2023
@jyavenard jyavenard added the merge-queue Applied to send a pull request to merge-queue label Aug 26, 2023
…MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator

https://bugs.webkit.org/show_bug.cgi?id=260742
rdar://114472398

Reviewed by Richard Robinson and Alan Baradlay.

Fix incorrect assertion.

Covered by tests.

* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::completeSeek):

Canonical link: https://commits.webkit.org/267314@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-267279main--macOS-Debug--ASSERTION-FAILED-WebCoreMediaSourcecompleteSeekSeeksCallbackAggregatorSeeksCallbackAggregator branch from b8aa86a to f005b55 Compare August 26, 2023 03:02
@webkit-commit-queue webkit-commit-queue merged commit f005b55 into WebKit:main Aug 26, 2023
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 267314@main (f005b55): https://commits.webkit.org/267314@main

Reviewed commits have been landed. Closing PR #17096 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 26, 2023
@jyavenard jyavenard deleted the eng/REGRESSION-267279main--macOS-Debug--ASSERTION-FAILED-WebCoreMediaSourcecompleteSeekSeeksCallbackAggregatorSeeksCallbackAggregator branch October 30, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants