-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Nullptr crash with :has(~sibling) invalidation in shadow tree #17222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullptr crash with :has(~sibling) invalidation in shadow tree #17222
Conversation
|
EWS run on previous version of this PR (hash 4c8ce26) Details |
cdumez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to use a RefPtr though. We're moving away from raw pointers.
4c8ce26 to
5e8f276
Compare
|
EWS run on current version of this PR (hash 5e8f276) Details |
https://bugs.webkit.org/show_bug.cgi?id=260902 rdar://110129945 Reviewed by Chris Dumez. * LayoutTests/fast/has-sibling-without-parent-crash-expected.html: Added. * LayoutTests/fast/has-sibling-without-parent-crash.html: Added. * Source/WebCore/style/StyleInvalidator.cpp: (WebCore::Style::Invalidator::invalidateStyleWithMatchElement): Elements with siblings don't have a parent element when they are parented to a shadow root. Canonical link: https://commits.webkit.org/267454@main
5e8f276 to
82d7f77
Compare
|
Committed 267454@main (82d7f77): https://commits.webkit.org/267454@main Reviewed commits have been landed. Closing PR #17222 and removing active labels. |
82d7f77
5e8f276
🧪 wpe-wk2🧪 gtk-wk2🧪 mac-AS-debug-wk2