Let the compiler generate more comparison operators in WebCore by cdumez · Pull Request #17326 · WebKit/WebKit

cdumez · 2023-09-01T04:41:18Z

`f61c511`

Let the compiler generate more comparison operators in WebCore
https://bugs.webkit.org/show_bug.cgi?id=261012

Reviewed by Darin Adler.

Let the compiler generate more comparison operators in WebCore now that we
support C++20.

* Source/WebCore/css/CSSProperty.h:
(WebCore::StylePropertyMetadata::operator== const): Deleted.
* Source/WebCore/css/StyleColor.h:
* Source/WebCore/css/color/CSSUnresolvedColorMix.cpp:
(WebCore::operator==):
* Source/WebCore/css/color/CSSUnresolvedColorMix.h:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::operator==): Deleted.
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSSelectorParser.h:
* Source/WebCore/css/typedom/numeric/CSSNumericType.cpp:
(WebCore::CSSNumericType::operator== const): Deleted.
* Source/WebCore/css/typedom/numeric/CSSNumericType.h:
* Source/WebCore/dom/ComposedTreeAncestorIterator.h:
(WebCore::ComposedTreeAncestorIterator::operator== const): Deleted.
* Source/WebCore/dom/MessagePortIdentifier.h:
(WebCore::operator==): Deleted.
* Source/WebCore/dom/QualifiedName.h:
(WebCore::QualifiedName::operator== const): Deleted.
* Source/WebCore/dom/SimpleRange.cpp:
(WebCore::operator==): Deleted.
* Source/WebCore/dom/SimpleRange.h:
* Source/WebCore/dom/SpaceSplitString.h:
(WebCore::SpaceSplitString::operator== const): Deleted.
* Source/WebCore/editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::replaceNodeFromPasteboard):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::checkPopoverValidity):
* Source/WebCore/html/LinkRelAttribute.h:
(WebCore::operator==): Deleted.
* Source/WebCore/html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::TextureAttachment::operator== const): Deleted.
(WebCore::WebGLFramebuffer::TextureLayerAttachment::operator== const): Deleted.
* Source/WebCore/html/canvas/WebGLFramebuffer.h:
* Source/WebCore/inspector/agents/InspectorNetworkAgent.h:
(WebCore::InspectorNetworkAgent::Intercept::operator== const): Deleted.
* Source/WebCore/layout/LayoutUnits.h:
(WebCore::Layout::operator==): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::AscentAndDescent::operator== const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineTypes.h:
(WebCore::Layout::InlineItemPosition::operator== const): Deleted.
* Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h:
(WebCore::InlineIterator::BoxLegacyPath::operator== const): Deleted.
* Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::operator== const): Deleted.
* Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h:
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::operator== const): Deleted.
* Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h:
(WebCore::InlineIterator::LineBoxIteratorModernPath::operator== const): Deleted.
* Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h:
(WebCore::Layout::LayoutContainingBlockChainIterator::operator== const): Deleted.
* Source/WebCore/loader/CrossOriginEmbedderPolicy.h:
(WebCore::operator==): Deleted.
* Source/WebCore/loader/CrossOriginOpenerPolicy.h:
(WebCore::operator==): Deleted.
* Source/WebCore/loader/PCMSites.h:
(WebCore::PCM::SourceSite::operator== const): Deleted.
(WebCore::PCM::AttributionDestinationSite::operator== const): Deleted.
* Source/WebCore/loader/PolicyContainer.h:
(WebCore::operator==): Deleted.
* Source/WebCore/loader/ResourceCryptographicDigest.h:
(WebCore::ResourceCryptographicDigest::operator== const): Deleted.
* Source/WebCore/page/ClientOrigin.h:
(WebCore::ClientOrigin::operator== const): Deleted.
* Source/WebCore/page/GlobalWindowIdentifier.h:
(WebCore::operator==): Deleted.
* Source/WebCore/page/InteractionRegion.h:
(WebCore::operator==): Deleted.
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/SecurityOriginData.h:
(WebCore::SecurityOriginData::Tuple::operator== const): Deleted.
* Source/WebCore/page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::Parameters::operator== const): Deleted.
* Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation const):
* Source/WebCore/page/scrolling/ScrollingConstraints.h:
(WebCore::AbsolutePositionConstraints::operator== const): Deleted.
(WebCore::FixedPositionViewportConstraints::operator== const): Deleted.
(WebCore::StickyPositionViewportConstraints::operator== const): Deleted.
* Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h:
(WebCore::ScrollableAreaParameters::operator== const): Deleted.
(WebCore::RequestedKeyboardScrollData::operator== const): Deleted.
* Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::ScrollbarHoverState::operator== const): Deleted.
* Source/WebCore/platform/Decimal.h:
* Source/WebCore/platform/EventTrackingRegions.cpp:
(WebCore::operator==): Deleted.
* Source/WebCore/platform/EventTrackingRegions.h:
* Source/WebCore/platform/KeyboardScroll.h:
(WebCore::KeyboardScroll::operator== const): Deleted.
* Source/WebCore/platform/LayoutUnit.h:
* Source/WebCore/platform/LengthPoint.h:
(WebCore::LengthPoint::operator== const): Deleted.
* Source/WebCore/platform/LengthSize.h:
(WebCore::operator==): Deleted.
* Source/WebCore/platform/ProcessQualified.h:
(WebCore::ProcessQualified::operator== const): Deleted.
* Source/WebCore/platform/RectEdges.h:
(WebCore::RectEdges::operator== const): Deleted.
* Source/WebCore/platform/RegistrableDomain.h:
* Source/WebCore/platform/ScriptExecutionContextIdentifier.h:
(WebCore::ProcessQualified<WTF::UUID>::operator== const): Deleted.
* Source/WebCore/platform/Timer.cpp:
(WebCore::operator==): Deleted.
* Source/WebCore/platform/audio/NowPlayingInfo.h:
(WebCore::NowPlayingInfo::operator== const): Deleted.

Canonical link: https://commits.webkit.org/267580@main

20186b3

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-01T04:47:13Z

EWS run on previous version of this PR (hash 0df9f83)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

darinadler · 2023-09-01T16:50:15Z

Source/WebCore/editing/cocoa/EditorCocoa.mm

Does this fix a bug? What did the code end up doing before?

Ah yes, I was a bit surprised the previous code was building. I am not sure what it ended up doing. The CSSParserContext constructor that takes in a Document& is not marked as explicit and I modified CSSParserContext's operator==() in this patch so maybe it was using that?

I can double check.

Yes, I was right. I was using CSSParserContext's operator==() :/
I will write a patch to make CSSParserContext's constructors explicit.

Amazing! That is so nuts. That may even have been costly enough that we get a tiny performance boost.

will land #17356 first to avoid behavior changes in this large refactoring patch.

darinadler · 2023-09-01T16:50:48Z

Source/WebCore/html/HTMLElement.cpp

Does this fix a bug? What did the code end up doing before?

darinadler · 2023-09-01T16:51:31Z

Source/WebCore/layout/LayoutUnits.h

I can’t figure out what rule you are using to decide when to use const& and when to just pass the structure. I would have expected just Position here, but I’m not sure it matters.

I'll switch to Position, I didn't realize the type was so small.

There are others like this even in this patch, such as LayoutUnit itself. I didn’t try to thoroughly search for such things.

darinadler · 2023-09-01T16:52:14Z

Source/WebCore/page/csp/ContentSecurityPolicy.cpp

Does this fix a bug? What did the code end up doing before?

darinadler · 2023-09-01T16:56:58Z

Source/WebCore/platform/Timer.cpp

I think we might, in the future, want to generate <=> instead of == here.

webkit-early-warning-system · 2023-09-01T19:41:36Z

EWS run on previous version of this PR (hash ab77a53)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	⏳ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	⏳ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-09-01T19:55:18Z

EWS run on previous version of this PR (hash 5f19a93)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-02T05:28:34Z

EWS run on current version of this PR (hash 20186b3)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=261012 Reviewed by Darin Adler. Let the compiler generate more comparison operators in WebCore now that we support C++20. * Source/WebCore/css/CSSProperty.h: (WebCore::StylePropertyMetadata::operator== const): Deleted. * Source/WebCore/css/StyleColor.h: * Source/WebCore/css/color/CSSUnresolvedColorMix.cpp: (WebCore::operator==): * Source/WebCore/css/color/CSSUnresolvedColorMix.h: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::operator==): Deleted. * Source/WebCore/css/parser/CSSParserContext.h: * Source/WebCore/css/parser/CSSSelectorParser.h: * Source/WebCore/css/typedom/numeric/CSSNumericType.cpp: (WebCore::CSSNumericType::operator== const): Deleted. * Source/WebCore/css/typedom/numeric/CSSNumericType.h: * Source/WebCore/dom/ComposedTreeAncestorIterator.h: (WebCore::ComposedTreeAncestorIterator::operator== const): Deleted. * Source/WebCore/dom/MessagePortIdentifier.h: (WebCore::operator==): Deleted. * Source/WebCore/dom/QualifiedName.h: (WebCore::QualifiedName::operator== const): Deleted. * Source/WebCore/dom/SimpleRange.cpp: (WebCore::operator==): Deleted. * Source/WebCore/dom/SimpleRange.h: * Source/WebCore/dom/SpaceSplitString.h: (WebCore::SpaceSplitString::operator== const): Deleted. * Source/WebCore/editing/cocoa/EditorCocoa.mm: (WebCore::Editor::replaceNodeFromPasteboard): * Source/WebCore/html/HTMLElement.cpp: (WebCore::checkPopoverValidity): * Source/WebCore/html/LinkRelAttribute.h: (WebCore::operator==): Deleted. * Source/WebCore/html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::TextureAttachment::operator== const): Deleted. (WebCore::WebGLFramebuffer::TextureLayerAttachment::operator== const): Deleted. * Source/WebCore/html/canvas/WebGLFramebuffer.h: * Source/WebCore/inspector/agents/InspectorNetworkAgent.h: (WebCore::InspectorNetworkAgent::Intercept::operator== const): Deleted. * Source/WebCore/layout/LayoutUnits.h: (WebCore::Layout::operator==): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h: (WebCore::Layout::InlineLevelBox::AscentAndDescent::operator== const): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineLineTypes.h: (WebCore::Layout::InlineItemPosition::operator== const): Deleted. * Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h: (WebCore::InlineIterator::BoxLegacyPath::operator== const): Deleted. * Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h: (WebCore::InlineIterator::BoxModernPath::operator== const): Deleted. * Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h: (WebCore::InlineIterator::LineBoxIteratorLegacyPath::operator== const): Deleted. * Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h: (WebCore::InlineIterator::LineBoxIteratorModernPath::operator== const): Deleted. * Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h: (WebCore::Layout::LayoutContainingBlockChainIterator::operator== const): Deleted. * Source/WebCore/loader/CrossOriginEmbedderPolicy.h: (WebCore::operator==): Deleted. * Source/WebCore/loader/CrossOriginOpenerPolicy.h: (WebCore::operator==): Deleted. * Source/WebCore/loader/PCMSites.h: (WebCore::PCM::SourceSite::operator== const): Deleted. (WebCore::PCM::AttributionDestinationSite::operator== const): Deleted. * Source/WebCore/loader/PolicyContainer.h: (WebCore::operator==): Deleted. * Source/WebCore/loader/ResourceCryptographicDigest.h: (WebCore::ResourceCryptographicDigest::operator== const): Deleted. * Source/WebCore/page/ClientOrigin.h: (WebCore::ClientOrigin::operator== const): Deleted. * Source/WebCore/page/GlobalWindowIdentifier.h: (WebCore::operator==): Deleted. * Source/WebCore/page/InteractionRegion.h: (WebCore::operator==): Deleted. * Source/WebCore/page/LocalFrameView.h: * Source/WebCore/page/SecurityOriginData.h: (WebCore::SecurityOriginData::Tuple::operator== const): Deleted. * Source/WebCore/page/ViewportConfiguration.h: (WebCore::ViewportConfiguration::Parameters::operator== const): Deleted. * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::reportViolation const): * Source/WebCore/page/scrolling/ScrollingConstraints.h: (WebCore::AbsolutePositionConstraints::operator== const): Deleted. (WebCore::FixedPositionViewportConstraints::operator== const): Deleted. (WebCore::StickyPositionViewportConstraints::operator== const): Deleted. * Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h: (WebCore::ScrollableAreaParameters::operator== const): Deleted. (WebCore::RequestedKeyboardScrollData::operator== const): Deleted. * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h: (WebCore::ScrollbarHoverState::operator== const): Deleted. * Source/WebCore/platform/Decimal.h: * Source/WebCore/platform/EventTrackingRegions.cpp: (WebCore::operator==): Deleted. * Source/WebCore/platform/EventTrackingRegions.h: * Source/WebCore/platform/KeyboardScroll.h: (WebCore::KeyboardScroll::operator== const): Deleted. * Source/WebCore/platform/LayoutUnit.h: * Source/WebCore/platform/LengthPoint.h: (WebCore::LengthPoint::operator== const): Deleted. * Source/WebCore/platform/LengthSize.h: (WebCore::operator==): Deleted. * Source/WebCore/platform/ProcessQualified.h: (WebCore::ProcessQualified::operator== const): Deleted. * Source/WebCore/platform/RectEdges.h: (WebCore::RectEdges::operator== const): Deleted. * Source/WebCore/platform/RegistrableDomain.h: * Source/WebCore/platform/ScriptExecutionContextIdentifier.h: (WebCore::ProcessQualified<WTF::UUID>::operator== const): Deleted. * Source/WebCore/platform/Timer.cpp: (WebCore::operator==): Deleted. * Source/WebCore/platform/audio/NowPlayingInfo.h: (WebCore::NowPlayingInfo::operator== const): Deleted. Canonical link: https://commits.webkit.org/267580@main

webkit-commit-queue · 2023-09-02T06:35:37Z

Committed 267580@main (f61c511): https://commits.webkit.org/267580@main

Reviewed commits have been landed. Closing PR #17326 and removing active labels.

cdumez self-assigned this Sep 1, 2023

cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Sep 1, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 1, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label Sep 1, 2023

cdumez marked this pull request as ready for review September 1, 2023 14:15

cdumez requested review from patrickangle and rniwa as code owners September 1, 2023 14:15

cdumez requested review from alanbaradlay, anttijk and darinadler September 1, 2023 14:16

darinadler approved these changes Sep 1, 2023

View reviewed changes

cdumez added merging-blocked Applied to prevent a change from being merged and removed merging-blocked Applied to prevent a change from being merged labels Sep 1, 2023

cdumez force-pushed the 261012_WebCore_operator==2 branch from 0df9f83 to ab77a53 Compare September 1, 2023 19:38

cdumez force-pushed the 261012_WebCore_operator==2 branch from ab77a53 to 5f19a93 Compare September 1, 2023 19:47

cdumez force-pushed the 261012_WebCore_operator==2 branch from 5f19a93 to 20186b3 Compare September 2, 2023 05:25

cdumez added the merge-queue Applied to send a pull request to merge-queue label Sep 2, 2023

webkit-commit-queue force-pushed the 261012_WebCore_operator==2 branch from 20186b3 to f61c511 Compare September 2, 2023 06:35

webkit-commit-queue merged commit f61c511 into WebKit:main Sep 2, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 2, 2023

Conversation

cdumez commented Sep 1, 2023 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Sep 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cdumez commented Sep 1, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Sep 1, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 1, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 1, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 2, 2023 •

edited

Loading