Skip to content

nullptr dereference in WebCore::WebSocket::close() #17349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Sep 2, 2023
Merged

nullptr dereference in WebCore::WebSocket::close() #17349

webkit-commit-queue merged 1 commit into from
Sep 2, 2023

Conversation

@ddkilzer
Copy link
Contributor

@ddkilzer ddkilzer commented Sep 1, 2023 •
edited by webkit-early-warning-system
Loading

3012086

nullptr dereference in WebCore::WebSocket::close()
https://bugs.webkit.org/show_bug.cgi?id=261037
<rdar://75425816>

Reviewed by Alex Christensen.

* Source/WebCore/Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::close):
- Add `nullptr` check for `m_channel`.

Canonical link: https://commits.webkit.org/267575@main

1c042a0

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@ddkilzer ddkilzer self-assigned this Sep 1, 2023
@ddkilzer ddkilzer added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Sep 1, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 1, 2023 •
edited
Loading

EWS run on current version of this PR (hash 1c042a0)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@ddkilzer ddkilzer added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 2, 2023
@ddkilzer
nullptr dereference in WebCore::WebSocket::close()
3012086 
https://bugs.webkit.org/show_bug.cgi?id=261037
<rdar://75425816>

Reviewed by Alex Christensen.

* Source/WebCore/Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::close):
- Add `nullptr` check for `m_channel`.

Canonical link: https://commits.webkit.org/267575@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/nullptr-dereference-in-WebCoreWebSocketclose branch from 1c042a0 to 3012086 Compare September 2, 2023 03:02
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Sep 2, 2023

Committed 267575@main (3012086): https://commits.webkit.org/267575@main

Reviewed commits have been landed. Closing PR #17349 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3012086 into WebKit:main Sep 2, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 2, 2023
@ddkilzer ddkilzer deleted the eng/nullptr-dereference-in-WebCoreWebSocketclose branch September 2, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achristensen07 achristensen07 achristensen07 approved these changes

Assignees

@ddkilzer ddkilzer

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddkilzer @webkit-early-warning-system @webkit-commit-queue @achristensen07