[GStreamer][MSE] FastSeek is broken #17541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=260607 Reviewed by NOBODY (OOPS!). Trigger the timeChanged notification only after the MediaSource has completed its seek operations. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp: (WebCore::MediaPlayerPrivateGStreamerMSE::doSeek):
Collaborator
|
EWS run on current version of this PR (hash eeb1ffa) Details
|
ntrrgc
reviewed
Sep 11, 2023
| GST_DEBUG_OBJECT(pipeline(), "[Seek] seeking to %s failed", toString(m_seekTarget.time).utf8().data()); | ||
| } | ||
| } else if (m_isSeeking && !(state == GST_STATE_PLAYING && pending == GST_STATE_PAUSED)) | ||
| } else if (!isMediaSource() && m_isSeeking && !(state == GST_STATE_PLAYING && pending == GST_STATE_PAUSED)) |
Contributor
There was a problem hiding this comment.
MediaPlayerPrivateGStreamerMSE overrides updateStates() with its own independent implementation.
Member
Author
There was a problem hiding this comment.
Noted... Anyway this PR is bit-rotten already after https://commits.webkit.org/267814@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eeb1ffa
eeb1ffa