Skip to content

Conversation

@mattwoodrow
Copy link
Contributor

@mattwoodrow mattwoodrow commented Sep 19, 2023

93bef58

Combining backface-visibility:hidden and backdrop-filter stops the backface from being hidden.
https://bugs.webkit.org/show_bug.cgi?id=249952
<rdar://103940530>

Reviewed by Simon Fraser.

Structural layers created for backdrop-filter should still have the double sided property set.

* LayoutTests/css3/filters/backdrop/backdrop-filter-with-backface-visibility-expected.html: Added.
* LayoutTests/css3/filters/backdrop/backdrop-filter-with-backface-visibility.html: Added.
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateBackfaceVisibility):

Canonical link: https://commits.webkit.org/268427@main

4109d37

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mattwoodrow mattwoodrow self-assigned this Sep 19, 2023
@mattwoodrow mattwoodrow added the CSS Cascading Style Sheets implementation label Sep 19, 2023
@mattwoodrow mattwoodrow added the merge-queue Applied to send a pull request to merge-queue label Sep 26, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/backdrop-filter-backface branch from 4109d37 to 86c5659 Compare September 26, 2023 02:06
…ckface from being hidden.

https://bugs.webkit.org/show_bug.cgi?id=249952
<rdar://103940530>

Reviewed by Simon Fraser.

Structural layers created for backdrop-filter should still have the double sided property set.

* LayoutTests/css3/filters/backdrop/backdrop-filter-with-backface-visibility-expected.html: Added.
* LayoutTests/css3/filters/backdrop/backdrop-filter-with-backface-visibility.html: Added.
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateBackfaceVisibility):

Canonical link: https://commits.webkit.org/268427@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/backdrop-filter-backface branch from 86c5659 to 93bef58 Compare September 26, 2023 02:10
@webkit-commit-queue webkit-commit-queue merged commit 93bef58 into WebKit:main Sep 26, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 268427@main (93bef58): https://commits.webkit.org/268427@main

Reviewed commits have been landed. Closing PR #17895 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants