Skip to content

Getting function name that includes space return empty string. #18612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

Getting function name that includes space return empty string. #18612

merged 1 commit into from
Oct 4, 2023

Conversation

@MenloDorian
Copy link

@MenloDorian MenloDorian commented Oct 4, 2023 •
edited by webkit-early-warning-system
Loading

17d73b1

Getting function name that includes space return empty string.
https://bugs.webkit.org/show_bug.cgi?id=262123
rdar://116406865

Reviewed by Yusuke Suzuki.

http://trac.webkit.org/r200423 introduced a site specific quirk (introduced back in 2016) to work around
the mathjs framework (at https://github.com/josdejong/mathjs) not supporting ES6 function names that
can contain white space.  See https://bugs.webkit.org/show_bug.cgi?id=157246.

Now that mathjs no longer has the offending code, plus both Chrome and Firefox also implements the ES6
spec on this, it's time to remove this quirk.

* LayoutTests/js/dom/regress-157246-expected.txt: Removed.
* LayoutTests/js/dom/regress-157246.html: Removed.
* LayoutTests/js/dom/script-tests/regress-157246.js: Removed.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/JavaScriptCore/runtime/JSFunction.cpp:
(JSC::JSFunction::reifyName):
* Source/JavaScriptCore/runtime/JSFunctionInlines.h:
(JSC::JSFunction::originalName):

Canonical link: https://commits.webkit.org/268838@main

b4dd76f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ❌ 🧪 jsc-mips-tests

@MenloDorian MenloDorian requested a review from a team as a code owner October 4, 2023 05:29
@MenloDorian MenloDorian self-assigned this Oct 4, 2023
@MenloDorian MenloDorian added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Oct 4, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 4, 2023 •
edited
Loading

EWS run on current version of this PR (hash b4dd76f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ❌ 🧪 jsc-mips-tests

Constellation
Constellation approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@MenloDorian MenloDorian added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 4, 2023
Getting function name that includes space return empty string.
17d73b1 
https://bugs.webkit.org/show_bug.cgi?id=262123
rdar://116406865

Reviewed by Yusuke Suzuki.

http://trac.webkit.org/r200423 introduced a site specific quirk (introduced back in 2016) to work around
the mathjs framework (at https://github.com/josdejong/mathjs) not supporting ES6 function names that
can contain white space.  See https://bugs.webkit.org/show_bug.cgi?id=157246.

Now that mathjs no longer has the offending code, plus both Chrome and Firefox also implements the ES6
spec on this, it's time to remove this quirk.

* LayoutTests/js/dom/regress-157246-expected.txt: Removed.
* LayoutTests/js/dom/regress-157246.html: Removed.
* LayoutTests/js/dom/script-tests/regress-157246.js: Removed.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/JavaScriptCore/runtime/JSFunction.cpp:
(JSC::JSFunction::reifyName):
* Source/JavaScriptCore/runtime/JSFunctionInlines.h:
(JSC::JSFunction::originalName):

Canonical link: https://commits.webkit.org/268838@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Getting-function-name-that-includes-space-return-empty-string branch from b4dd76f to 17d73b1 Compare October 4, 2023 09:05
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Oct 4, 2023

Committed 268838@main (17d73b1): https://commits.webkit.org/268838@main

Reviewed commits have been landed. Closing PR #18612 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 17d73b1 into WebKit:main Oct 4, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 4, 2023
@MenloDorian MenloDorian deleted the eng/Getting-function-name-that-includes-space-return-empty-string branch October 4, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@MenloDorian MenloDorian

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MenloDorian @webkit-early-warning-system @webkit-commit-queue @Constellation