Ignore calc() values on colgroup elements#18900
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Oct 11, 2023
Merged
Ignore calc() values on colgroup elements#18900webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Ahmad-S792
added
the
Tables
Collaborator
|
EWS run on previous version of this PR (hash dadb82c) Details
|
Ahmad-S792
force-pushed
the
fix253841-colgroup-calc-css-tables-fix
branch
from
dadb82c to
94071c8
Compare
Collaborator
|
EWS run on current version of this PR (hash 94071c8) Details |
Contributor
Author
|
WOW! Not crashing / asserting now. :-) Another win.. |
alanbaradlay
approved these changes
Oct 11, 2023
https://bugs.webkit.org/show_bug.cgi?id=253841 rdar://problem/106692191 Reviewed by Alan Baradlay. This patch aligns WebKit to Blink / Chromium and Gecko / Firefox. Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=193912 This patch add condition to ignore calc() values on 'colgroup' elements to align with web-spec. * Source/WebCore/rendering/AutoTableLayout.cpp: (AutoTableLayout::fullRecalc): Add 'isCalculated' condition * LayoutTests/fast/table/calculated-width-on-col-within-colgroup.html: Add Test Case * LayoutTests/fast/table/calculated-width-on-col-within-colgroup-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/269200@main
webkit-commit-queue
force-pushed
the
fix253841-colgroup-calc-css-tables-fix
branch
from
94071c8 to
a47442a
Compare
Collaborator
|
Committed 269200@main (a47442a): https://commits.webkit.org/269200@main Reviewed commits have been landed. Closing PR #18900 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a47442a
94071c8