[SVG] Add strokeContains fast path #19330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
EWS run on previous version of this PR (hash 7fd4966) Details
|
🛠 tv-sim
Constellation
force-pushed
the
eng/SVG-Add-strokeContains-fast-path
branch
from
7fd4966 to
89ec2fa
Compare
Collaborator
|
EWS run on previous version of this PR (hash 89ec2fa) Details
|
Constellation
force-pushed
the
eng/SVG-Add-strokeContains-fast-path
branch
from
89ec2fa to
bb2f030
Compare
Collaborator
|
EWS run on previous version of this PR (hash bb2f030) Details
|
heycam
approved these changes
Oct 24, 2023
Contributor
There was a problem hiding this comment.
TIL stroke-miterlimit actually applies to rect and not just path, line, and polygon!
Comment on lines
86
to
87
Contributor
There was a problem hiding this comment.
This comment is now out of date and I think we can remove it.
Member
Author
There was a problem hiding this comment.
Sounds good! Removed.
Comment on lines
83
to
84
Constellation
force-pushed
the
eng/SVG-Add-strokeContains-fast-path
branch
from
bb2f030 to
d468c64
Compare
Collaborator
|
EWS run on current version of this PR (hash d468c64) Details
|
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=263430 rdar://problem/117439322 Reviewed by Cameron McCormack. This is one step of the patch series implementing approximate repainting rect for SVG path, derived from blink's work[1]. This patch adds strokeContains optimization. The key is that we can use approximateStrokeBoundingBox to filter out the candidates Instead of strokeBoundingBox since approximateStrokeBoundingBox is always larger than strokeBoundingBox. And approximateStrokeBoundingBox is incredibly faster than strokeBoundingBox. We also extend our fast path handling for SVG Rect. [1]: https://bugs.chromium.org/p/chromium/issues/detail?id=435097 * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.cpp: (WebCore::LegacyRenderSVGEllipse::updateShapeFromElement): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp: (WebCore::LegacyRenderSVGPath::updateShapeFromElement): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.cpp: (WebCore::LegacyRenderSVGRect::updateShapeFromElement): (WebCore::LegacyRenderSVGRect::canUseStrokeHitTestFastPath const): (WebCore::LegacyRenderSVGRect::definitelyHasSimpleStroke const): (WebCore::LegacyRenderSVGRect::shapeDependentStrokeContains): (WebCore::LegacyRenderSVGRect::shapeDependentFillContains const): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp: (WebCore::LegacyRenderSVGShape::strokeContains): (WebCore::LegacyRenderSVGShape::approximateStrokeBoundingBox const): (WebCore::LegacyRenderSVGShape::updateRepaintBoundingBox): (WebCore::LegacyRenderSVGShape::hasSmoothStroke const): Deleted. * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h: Canonical link: https://commits.webkit.org/269745@main
webkit-commit-queue
force-pushed
the
eng/SVG-Add-strokeContains-fast-path
branch
from
d468c64 to
95809c7
Compare
Collaborator
|
Committed 269745@main (95809c7): https://commits.webkit.org/269745@main Reviewed commits have been landed. Closing PR #19330 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
95809c7
d468c64
🧪 ios-wk2-wpt🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-AS-debug-wk2