Add explicit to some single argument constructors #19649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
requested review from
cdumez,
graouts,
marcoscaceres and
rniwa
as code owners
annevk
added
the
DOM
Collaborator
|
EWS run on current version of this PR (hash 9b957ad)
|
cdumez
approved these changes
Oct 27, 2023
https://bugs.webkit.org/show_bug.cgi?id=263793 rdar://117597310 Reviewed by Chris Dumez. During development of https://bugs.webkit.org/show_bug.cgi?id=263435 I copied some incorrect prior art: 1. Single argument constructors should use explicit. 2. "static constexpr" should be in that order. This change addresses 2 with the exception of third party code. It only addresses 1 for code in Source/WebCore/html/shadow. * Source/WebCore/Modules/model-element/HTMLModelElement.h: * Source/WebCore/dom/Node.h: * Source/WebCore/html/HTMLDivElement.h: * Source/WebCore/html/HTMLFormControlElement.h: * Source/WebCore/html/HTMLFrameElementBase.h: * Source/WebCore/html/HTMLFrameOwnerElement.h: * Source/WebCore/html/HTMLFrameSetElement.h: * Source/WebCore/html/HTMLImageElement.h: * Source/WebCore/html/HTMLLIElement.h: * Source/WebCore/html/HTMLMediaElement.h: * Source/WebCore/html/HTMLOptionElement.h: * Source/WebCore/html/HTMLPlugInElement.h: * Source/WebCore/html/HTMLProgressElement.h: * Source/WebCore/html/shadow/DateTimeFieldElement.h: * Source/WebCore/html/shadow/DetailsMarkerControl.h: * Source/WebCore/html/shadow/ProgressShadowElement.h: * Source/WebCore/html/shadow/SliderThumbElement.h: * Source/WebCore/html/shadow/SpinButtonElement.h: * Source/WebCore/html/shadow/TextControlInnerElements.h: * Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h: * Source/WebCore/html/track/TextTrackCue.h: * Source/WebCore/mathml/MathMLMathElement.h: * Source/WebCore/mathml/MathMLPresentationElement.h: * Source/WebCore/mathml/MathMLRowElement.h: * Source/WebCore/mathml/MathMLTokenElement.h: * Source/WebCore/svg/SVGPathSegImpl.h: Canonical link: https://commits.webkit.org/269865@main
webkit-commit-queue
force-pushed
the
eng/Add-explicit-to-some-single-argument-constructors
branch
from
9b957ad to
f3216a0
Compare
Collaborator
|
Committed 269865@main (f3216a0): https://commits.webkit.org/269865@main Reviewed commits have been landed. Closing PR #19649 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
annevk
deleted the
eng/Add-explicit-to-some-single-argument-constructors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f3216a0
9b957ad
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 gtk-wk2🧪 api-ios🛠 tv🧪 mac-AS-debug-wk2🛠 watch