[WebRTC] Add missing assertion to rtp_format_h265.cc #20352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
EWS run on previous version of this PR (hash 6dcab55) Details
|
youennf
approved these changes
Nov 13, 2023
Contributor
youennf
left a comment
youennf
left a comment
There was a problem hiding this comment.
I would remove the RTC_DCHECK, I am not sure they add much.
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc
Outdated
Show resolved
Hide resolved
ddkilzer
changed the title
ddkilzer
force-pushed
the
eng/WebRTC-Add-missing-assertions-to-rtp_format_h264-ccrtp_format_h265-cc
branch
from
6dcab55 to
cac0858
Compare
Collaborator
|
EWS run on current version of this PR (hash cac0858) Details
|
ddkilzer
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=264648 <rdar://118259276> Reviewed by Youenn Fablet. * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h265.cc: (webrtc::RtpPacketizerH265::NextAggregatePacket): - Add RTC_CHECK_LE() bounds check to match the one in webrtc::RtpPacketizerH264::NextAggregatePacket(). * Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-Add-missing-assertion-to-rtp_format_h265.cc.patch: Add. Canonical link: https://commits.webkit.org/270677@main
webkit-commit-queue
force-pushed
the
eng/WebRTC-Add-missing-assertions-to-rtp_format_h264-ccrtp_format_h265-cc
branch
from
cac0858 to
746712e
Compare
Collaborator
|
Committed 270677@main (746712e): https://commits.webkit.org/270677@main Reviewed commits have been landed. Closing PR #20352 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
ddkilzer
deleted the
eng/WebRTC-Add-missing-assertions-to-rtp_format_h264-ccrtp_format_h265-cc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
746712e
cac0858
🛠 ios🛠 mac🛠 wpe🛠 wincairo🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 api-gtk🛠 tv🧪 mac-AS-debug-wk2🛠 tv-sim🧪 mac-wk2-stress🛠 watch🛠 watch-sim